10000 `plotly_relayouting` event: live updates during panning/zooming by antoinerg · Pull Request #3888 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

plotly_relayouting event: live updates during panning/zooming #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 23, 2019
Merged

plotly_relayouting event: live updates during panning/zooming #3888

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f8203a3
plotly_relayouting for cartesian plots
antoinerg May 21, 2019
4b0a0fd
plotly_relayouting for geo plots
antoinerg May 21, 2019
4520a21
plotly_relayouting for ternary plots
antoinerg May 22, 2019
6852981
plotly_relayouting for polar plots
antoinerg May 22, 2019
e268cda
plotly_relayouting for mapbox plots
antoinerg May 22, 2019
7a66daf
plotly_relayouting for gl3d plots
antoinerg May 22, 2019
2545746
improve coverage of plotly_relayouting for geo plots
antoinerg May 22, 2019
082f1d2
improve tests of plotly_relayouting for gl3d plots
antoinerg May 22, 2019
12658db
improve coverage of plotly_relayouting for polar plots
antoinerg May 22, 2019
b0ae7f8
Merge branch 'master' into event-drag
etpinard May 23, 2019
a76a52a
cartesian_interact: update assert values due to timing change
antoinerg May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
plotly_relayouting for gl3d plots
  • Loading branch information
@antoinerg
antoinerg committed May 22, 2019
commit 7a66dafc5e2b38a907b7757849240f432d6e2372
9 changes: 9 additions & 0 deletions src/plots/gl3d/scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,15 @@ function initializeGLPlot(scene, pixelRatio, canvas, gl) {
}
}, passiveSupported ? {passive: false} : false);

scene.glplot.canvas.addEventListener('mousemove', function() {
if(scene.fullSceneLayout.dragmode === false) return;
if(scene.camera.mouseListener.buttons === 0) return;

var update = {};
update[scene.id + '.camera'] = getLayoutCamera(scene.camera);
scene.graphDiv.emit('plotly_relayouting', update);
});

if(!scene.staticMode) {
scene.glplot.canvas.addEventListener('webglcontextlost', function(event) {
if(gd && gd.emit) {
Expand Down
48 changes: 48 additions & 0 deletions test/jasmine/tests/gl3d_plot_interact_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,54 @@ describe('Test gl3d drag and wheel interactions', function() {
.catch(failTest)
.then(done);
});

it('@gl should fire plotly_relayouting events', function(done) {
var sceneLayout, sceneTarget, relayoutCallback, relayoutingCallback;

var mock = {
data: [
{ type: 'scatter3d', x: [1, 2, 3], y: [2, 3, 1], z: [3, 1, 2] }
],
layout: {
scene: { camera: { projection: {type: 'orthographic'}, eye: { x: 0.1, y: 0.1, z: 1 }}},
width: 400, height: 400
}
};

var nsteps = 10;
function _drag(target, start, end, n) {
return new Promise(function(resolve) {
mouseEvent('mousedown', start[0], start[1], {element: target, buttons: 1});
var dx = (end[0] - start[0]) / n;
var dy = (end[1] - start[1]) / n;
for(var i = 1; i <= n; i++) {
mouseEvent('mousemove', start[0] + dx * n, start[1] + dy * n, {element: target, buttons: 1});
}
mouseEvent('mouseup', end[0], end[1], {element: target, buttons: 1});
setTimeout(resolve, 0);
});
}

Plotly.plot(gd, mock)
.then(function() {
relayoutCallback = jasmine.createSpy('relayoutCallback');
gd.on('plotly_relayout', relayoutCallback);

relayoutingCallback = jasmine.createSpy('relayoutingCallback');
gd.on('plotly_relayouting', relayoutingCallback);

sceneLayout = gd._fullLayout.scene;
sceneTarget = gd.querySelector('.svg-container .gl-container #scene canvas');

return _drag(sceneTarget, [200, 200], [100, 100], nsteps);
})
.then(function() {
expect(relayoutCallback).toHaveBeenCalledTimes(1);
expect(relayoutingCallback).toHaveBeenCalledTimes(nsteps);
})
.catch(failTest)
.then(done);
});
});

describe('Test gl3d relayout calls', function() {
Expand Down
0