8000 Introducing histogram* bingroup attributes by etpinard · Pull Request #3845 · plotly/plotly.js · GitHub
[go: up one dir, main page]

Skip to content

Introducing histogram* bingroup attributes #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 21, 2019
Prev Previous commit
improve comments
  • Loading branch information
etpinard committed May 20, 2019
commit b8ea71eaa2deb200bdbd6a359a6e256516b5aa34
1 change: 1 addition & 0 deletions src/traces/histogram/calc.js
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ function calcAllAutoBins(gd, trace, pa, mainData, _overlayEdgeCase) {
}

// TODO how does work with bingroup ????
// - https://github.com/plotly/plotly.js/issues/3881
//
// Edge case: single-valued histogram overlaying others
// Use them all together to calculate the bin size for the single-valued one
Expand Down
2 changes: 0 additions & 2 deletions test/jasmine/tests/histogram_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,6 @@ describe('Test histogram', function() {
]);
});

// TODO figure out what to do in this case!
it('should be able to group histogram and histogram2d* traces together', function() {
gd = {
data: [
Expand Down Expand Up @@ -447,7 +446,6 @@ describe('Test histogram', function() {
{bingroup: '1', type: 'histogram', y: [2, 3], xaxis: 'x2', yaxis: 'y2'},
// this one does not have to match either
// (it's a histogram2d* traces), but it can be grouped
// TODO should this be just "bingroup"???
{xbingroup: '1', ybingroup: '1', type: 'histogram2d', x: [3, 4], y: [3, 4]}
],
layout: {}
Expand Down
0