8000 Fix axis automargin push offset by etpinard · Pull Request #3510 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Fix axis automargin push offset #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2019
Merged

Fix axis automargin push offset #3510

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37f81b8
fix axis automargin push offset value
etpinard Feb 4, 2019
bc314c2
improve baseline that have axis.automargin turned on
etpinard Feb 4, 2019
53b62b3
add 1-px tolerance to some automargin assertions
etpinard Feb 4, 2019
4a0b1a5
add axis automargin + zero margins mock
etpinard Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
Prev Previous commit
Next Next commit
add 1-px tolerance to some automargin assertions
  • Loading branch information
@etpinard
etpinard committed Feb 4, 2019
commit 53b62b3c1b17536930a003fce74d6fc1fa65b841
4 changes: 2 additions & 2 deletions test/jasmine/tests/axes_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3150,7 +3150,7 @@ describe('Test axes', function() {
})
.then(function() {
var size = gd._fullLayout._size;
expect(size.l).toBe(previousSize.l);
expect(size.l).toBeWithin(previousSize.l, 1.1);
expect(size.r).toBe(previousSize.r);
expect(size.b).toBe(previousSize.b);
expect(size.t).toBe(previousSize.t);
Expand Down Expand Up @@ -3187,7 +3187,7 @@ describe('Test axes', function() {
expect(size.l).toBe(initialSize.r);
expect(size.r).toBe(previousSize.l);
expect(size.b).toBe(initialSize.b);
expect(size.t).toBe(previousSize.b);
expect(size.t).toBeWithin(previousSize.b, 1.1);

return Plotly.relayout(gd, {
'xaxis.automargin': false,
Expand Down
0