10000 Display a colorscale when scatter3d.line.showscale is set by archmoj · Pull Request #3384 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Display a colorscale when scatter3d.line.showscale is set #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 14, 2019
Merged

Display a colorscale when scatter3d.line.showscale is set #3384

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d245c2d
fix issue 2862 by showing colorbar when scatter line has scale e.g. s…
archmoj Jan 2, 2019
f9dce0d
handling the case of undefined container
archmoj Jan 2, 2019
991face
return after setting colorscale
archmoj Jan 2, 2019
912e554
apply line colorscale case for scatter3d only
archmoj Jan 2, 2019
707c017
revised code with new mock
archmoj Jan 3, 2019
60b87a2
new mock and baseline to lock issue 2862
archmoj Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
return after setting colorscale
  • Loading branch information
@archmoj
archmoj committed Jan 2, 2019
commit 991face1c6759300efa875d8262c22810c2d9f55
2 changes: 2 additions & 0 deletions src/components/colorbar/connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,7 @@ module.exports = function connectColorbar(gd, cd, moduleOpts) {
cb.fillgradient(scl)
.zrange([container[moduleOpts.min], container[moduleOpts.max]])
.options(container.colorbar)();

return;
}
};
0