world > object

plotly · archmoj · Nov 30, 2018 · Nov 27, 2018 · Nov 27, 2018 · Nov 27, 2018
commit 7da5c089597297e8c0a2029895d93901e51e71d5
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -84,7 +84,7 @@
     "gl-select-box": "^1.0.2",
     "gl-spikes2d": "^1.0.1",
     "gl-streamtube3d": "^1.1.1",
-    "gl-surface3d": "git://github.com/gl-vis/gl-surface3d.git#7fd01b7ba97bb6b09023bf9f97430081ac72eccc",
+    "gl-surface3d": "git://github.com/gl-vis/gl-surface3d.git#e67d13b4491a2f18eeb284afc9172f8eee21f62e",
     "gl-text": "^1.1.6",
     "glslify": "^6.3.1",
     "has-hover": "^1.0.1",

diff --git a/src/plots/gl3d/scene.js b/src/plots/gl3d/scene.js
@@ -382,8 +382,8 @@ function computeTraceBounds(scene, trace, bounds) {
         }
 
         if(trace.type === 'surface') {
-            bounds[0][d] += trace._worldOffset[d];
-            bounds[1][d] += trace._worldOffset[d];
+            bounds[0][d] += trace._objectOffset[d];
+            bounds[1][d] += trace._objectOffset[d];
         }
     }
 }

diff --git a/src/traces/surface/convert.js b/src/traces/surface/convert.js
@@ -417,7 +417,7 @@ proto.update = function(data) {
     }
 
     for(i = 0; i < 3; i++) {
-        data._worldOffset[i] = this.midValues[i] = 0.5 * (this.minValues[i] + this.maxValues[i]);
+        data._objectOffset[i] = this.midValues[i] = 0.5 * (this.minValues[i] + this.maxValues[i]);
     }
 
     for(i = 0; i < 3; i++) {
@@ -534,13 +534,13 @@ proto.update = function(data) {
         params.vertexColor = true;
     }
 
-    params.worldOffset = [
-        data._worldOffset[0],
-        data._worldOffset[1],
-        data._worldOffset[2]
+    params.objectOffset = [
+        data._objectOffset[0],
+        data._objectOffset[1],
+        data._objectOffset[2]
     ];
 
-    params.worldScale = [
+    params.objectScale = [
         scaleFactor[0],
         scaleFactor[1],
         scaleFactor[2]

diff --git a/src/traces/surface/defaults.js b/src/traces/surface/defaults.js
@@ -35,7 +35,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     traceOut._xlength = (Array.isArray(x) && Lib.isArrayOrTypedArray(x[0])) ? z.length : z[0].length;
     traceOut._ylength = z.length;
 
-    traceOut._worldOffset = [0, 0, 0];
+    traceOut._objectOffset = [0, 0, 0];
 
     var handleCalendarDefaults = Registry.getComponentMethod('calendars', 'handleTraceDefaults');
     handleCalendarDefaults(traceIn, traceOut, ['x', 'y', 'z'], layout);