8000 Joyplots etpinard by Kully · Pull Request #3222 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Joyplots etpinard #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2018
Merged

Joyplots etpinard #3222

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44fa269
inherit violin 'width' from box.width
etpinard Nov 6, 2018
f5ba38c
rm useless attrs in test mock
etpinard Nov 6, 2018
34722d3
mention that 'width' is in data coordinates
etpinard Nov 6, 2018
d1aed48
ignore box/violin *gap and *groupgap when 'width' is set
etpinard Nov 6, 2018
c70f7d5
do not coerce scale* attrs when violin 'width' is set
etpinard Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
inherit violin 'width' from box.width
  • Loading branch information
@etpinard
etpinard committed Nov 6, 2018
commit 44fa26926c4beaba5bc9f22f7b629bfd498a0cb3
9 changes: 2 additions & 7 deletions src/traces/violin/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,18 +136,13 @@ module.exports = {
].join(' ')
}),

width: {
valType: 'number',
min: 0,
role: 'info',
dflt: 0,
editType: 'calc',
width: extendFlat({}, boxAttrs.width, {
description: [
'Sets the width of the violin.',
'If *0* (default value) the width is automatically selected based on the positions',
'of other violin traces in the same subplot.',
].join(' ')
},
}),

marker: boxAttrs.marker,
text: boxAttrs.text,
Expand Down
0