8000 2951 contrasting pie and bar inside text by rmoestl · Pull Request #3130 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

2951 contrasting pie and bar inside text #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 25, 2018
Merged

2951 contrasting pie and bar inside text #3130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
58be4f4
Correct typo in a pie attribute description
rmoestl Sep 27, 2018
cabd0be
Fix minor typos in pie_test.js
rmoestl Sep 27, 2018
487f73e
Use contrasting inside text color for pie by default [2951]
rmoestl Oct 11, 2018
6c8f2af
Use contrasting inside text color for bar by default [2951]
rmoestl Oct 11, 2018
4b02d36
Update pie baselines b/c inside text defaults to contrasting now [2951]
rmoestl Oct 15, 2018
66e26db
Update bar baselines b/c inside text defaults to contrasting now [2951]
rmoestl Oct 15, 2018
66fc665
Make pie font properties arrayOk [2951]
rmoestl Oct 16, 2018
df0d6c3
Fix style of bar 'outside' labels being pushed 'inside' [2951]
rmoestl Oct 17, 2018
d2dbd28
Fix baseline image differences resulting from parallel work [2951]
rmoestl Oct 18, 2018
e26bc50
Retain bar text styles throughout selection as well [2951]
rmoestl Oct 19, 2018
172e3e9
Test that bar opacity is considered for contrasting text color [2951]
rmoestl Oct 19, 2018
2b3a78b
Move rgb conversion into assert methods for bar and pie tests [2951]
rmoestl Oct 19, 2018
3bc3aa2
Improve comment in bar/defaults.js [2951]
rmoestl Oct 19, 2018
61b9d50
Improve some variable names in pie/plot.js [2951]
rmoestl Oct 19, 2018
a27d278
Fix contrasting text color for bars without explicit marker color [2951]
rmoestl Oct 23, 2018
3ccc68b
Test contrasting inside text colors for standard pie colors [2951]
rmoestl Oct 23, 2018
69b35b5
Update baseline for mathjax.json [2951]
rmoestl Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update bar baselines b/c inside text defaults to contrasting now [2951]
  • Loading branch information
@rmoestl
rmoestl committed Oct 19, 2018
commit 66e26db69499270032449a2abb8d3b5b1f1cb09c
Binary file modified test/image/baselines/bar_attrs_group_norm.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/image/baselines/bar_attrs_relative.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
0