Scattergl improvements for: fill tozero with bad values fix, fills layering fix, add some line.shape values #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation 7 Commits 27 Checks 0 Files changed

Merged

Scattergl improvements for: fill tozero with bad values fix, fills layering fix, add some line.shape values #3087

Changes from 1 commit

Commits

Show all changes
27 commits

Select commit Hold shift + click to select a range

1c52fa6
Merge pull request #1 from plotly/master
ErwanMAS Sep 8, 2018

bdc94ce
Merge pull request #2 from plotly/master
ErwanMAS Sep 12, 2018

e69e2d6
Merge pull request #3 from plotly/master
ErwanMAS Sep 30, 2018

52020a9
Fix https://codepen.io/erwanmas/pen/JaymVr
ErwanMAS Sep 7, 2018

304083e
fix lint issues
ErwanMAS Sep 7, 2018

05343b8
only one big mock for the 3 tests
ErwanMAS Sep 7, 2018

51d6688
add simple shape for line in scattergl
ErwanMAS Sep 11, 2018

831f508
add shape to scattergl
ErwanMAS Sep 12, 2018

39eb303
remove some empty lines
ErwanMAS Sep 12, 2018

283b50d
update of the baseline images
ErwanMAS Sep 12, 2018

02e924c
we don't reuse scatter files ... because partialy impelemented
ErwanMAS Sep 12, 2018

a49e6d0
fix lint
ErwanMAS Sep 13, 2018

5d3a924
- remove line_shape_defaults.js , moe the code into scattergl/default…
ErwanMAS Sep 14, 2018

f670af2
fix lint issues
ErwanMAS Sep 14, 2018

93b61bc
- modify one test to add GL/REG version
ErwanMAS Sep 30, 2018

346a32a
- remove some console.log
ErwanMAS Sep 30, 2018

9cf7172
add baseline for the gl2d_order_error
ErwanMAS Sep 30, 2018

987e6cd
fix lint issues
ErwanMAS Sep 30, 2018

95c602e
last version , we display by order only .
ErwanMAS Oct 1, 2018

be43294
- fix gl2d_scatter_fill_self_next ( rollback the baselines test/image…
ErwanMAS Oct 5, 2018

126e29c
fix lint issues
ErwanMAS Oct 5, 2018

9cc641a
Merge branch 'master' into pr-2979
etpinard Oct 5, 2018

075bd14
DRY up fill ordering logic
etpinard Oct 5, 2018

6ae6283
DRY up scatter / scattergl fill ordering in linkTraces
etpinard Oct 5, 2018

54d8240
improve gl2d_scatter_fill_self_next_vs_nogl mock
etpinard Oct 9, 2018

d8297a0
improve line.shape 'vh' by @ErwanMAS
etpinard Oct 11, 2018

d708132
merge 'push' calls together
etpinard Oct 11, 2018

File filter

Filter by extension

Filter by extension All 0 file types selected

Viewed files

Conversations

Failed to load comments.

Loading

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

Prev Previous commit

Next Next commit

Merge pull request #3 from plotly/master

catchup

Loading branch information

ErwanMAS authored Sep 30, 2018

commit e69e2d60869b2d62da763a6df66eccf7c4fc70fc

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Scattergl improvements for: fill tozero with bad values fix, fills layering fix, add some line.shape values #3087

Uh oh!

Diff view

Diff view

Uh oh!

There are no files selected for viewing

This merge commit was added into this branch cleanly.