8000 Add redrawReglTraces subroutine by etpinard · Pull Request #3067 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Add redrawReglTraces subroutine #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 2, 2018
Merged

Add redrawReglTraces subroutine #3067

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81eb48b
introduce redrawReglTraces subroutine
etpinard Oct 2, 2018
0243451
:hocho: obsolete sortBasePlotModules
etpinard Oct 2, 2018
dcacd78
use redrawReglTraces on drag
etpinard Oct 2, 2018
68dfbc1
use redrawReglTraces on polar drag
etpinard Oct 2, 2018
c02330c
fix #2797 - clear full canvas and use redrawReglTraces on selections
etpinard Oct 2, 2018
02263b9
use redrawReglTraces in edit subroutines
etpinard Oct 2, 2018
f179c2f
skip canvas/context size mismatch test on CI
etpinard Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to l 8000 oad comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🔪 obsolete sortBasePlotModules 
... no need for this now that we have redrawReglTraces
  • Loading branch information
@etpinard
etpinard committed Oct 2, 2018
commit 02434517bd82b2dd1f0a903e0b441946b617a467
4 changes: 0 additions & 4 deletions src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ var Color = require('../components/color');
var BADNUM = require('../constants/numerical').BADNUM;

var axisIDs = require('../plots/cartesian/axis_ids');
var sortBasePlotModules = require('./sort_modules').sortBasePlotModules;

var animationAttrs = require('./animation_attributes');
var frameAttrs = require('./frame_attributes');
Expand Down Expand Up @@ -487,9 +486,6 @@ plots.supplyDefaults = function(gd, opts) {
if(!skipUpdateCalc && oldCalcdata.length === newFullData.length) {
plots.supplyDefaultsUpdateCalc(oldCalcdata, newFullData);
}

// sort base plot modules for consistent ordering
newFullLayout._basePlotModules.sort(sortBasePlotModules);
};

plots.supplyDefaultsUpdateCalc = function(oldCalcdata, newFullData) {
Expand Down
25 changes: 0 additions & 25 deletions src/plots/sort_modules.js
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions test/jasmine/tests/plots_test.js
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -153,26 +153,6 @@ describe('Test Plots', function() {
testSanitizeMarginsHasBeenCalledOnlyOnce(gd);
});

it('should sort base plot modules on fullLayout object', function() {
var gd = Lib.extendDeep({}, require('@mocks/plot_types.json'));
gd.data.unshift({type: 'scattergl'});
gd.data.push({type: 'splom'});

supplyAllDefaults(gd);
var names = gd._fullLayout._basePlotModules.map(function(m) {
return m.name;
});

expect(names).toEqual([
'splom',
'cartesian',
'gl3d',
'geo',
'pie',
'ternary'
]);
});
});

describe('Plots.supplyLayoutGlobalDefaults should', function() {
Expand Down
0