8000 README and CONTRIBUTING updates by etpinard · Pull Request #3 · plotly/plotly.js · GitHub
[go: up one dir, main page]

Skip to content

README and CONTRIBUTING updates #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 17, 2015
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add Contributing.md first pass
  • Loading branch information
etpinard committed Nov 15, 2015
commit 0b1843463f1828d6c448f137df880d06a9665562
70 changes: 69 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1 +1,69 @@
yolos!
# Contributing to plotly.js

### Opening issues

Search for existing and closed issues. If your problem or idea is not addressed
yet, [please open a new issue](https://github.com/plotly/plotly.js/issues/new).

### Development

**Prerequisites**:

- git
- [node.js](https://nodejs.org/en/). We recommend using node.js 4.2.1 (LTS).
Upgrading and managing node versions can be easily done using
[`nvm`](https://github.com/creationix/nvm) or its Windows alternatives.

**Step 1** Clone the plotly.js repo and install its dependencies

```
git clone https://github.com/plotly/plotly.js.git
cd plotly.js
npm install
```

**Step 2** Build plotly.js

```
npm run build
```

The build script combines:

- `npm run preprocess`, which converts `scss` and `svg` assets to `js` and
- `npm run bundle`, which runs
[browserify](https://github.com/substack/node-browserify) on the source files

**Step 3** Start test dashboard

```
npm run start-test_dashboard
```

This command bundles up the source files with source maps, starts
[watchify](https://github.com/substack/watchify) file watcher (making the your
dev plotly.js bundle update every time a source file is saved) and opens up
a tab in your browser.

### Testing

```
npm test
```

Jasmine tests are run in a browser using
[karma](https://github.com/karma-runner/karma)

```
npm run test-jasmine
```

Image pixel comparison tests are run in a docker container

```
npm run test-image
```

### Repo organization

### Coding style
0