8000 fix layer ordering of scatter subtypes by alexcjohnson · Pull Request #2978 · plotly/plotly.js · GitHub
[go: up one dir, main page]

Skip to content

fix layer ordering of scatter subtypes #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
put back text styling in scattergeo
  • Loading branch information
alexcjohnson committed Sep 7, 2018
commit 7c54fc2f0bd38ecac52c314b736e86ef035c3511
1 change: 1 addition & 0 deletions src/traces/scatter/style.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,6 @@ function styleOnSelect(gd, cd) {
module.exports = {
style: style,
stylePoints: stylePoints,
styleText: styleText,
styleOnSelect: styleOnSelect
};
5 changes: 4 additions & 1 deletion src/traces/scattergeo/style.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ var d3 = require('d3');
var Drawing = require('../../components/drawing');
var Color = require('../../components/color');

var stylePoints = require('../scatter/style').stylePoints;
var scatterStyle = require('../scatter/style');
var stylePoints = scatterStyle.stylePoints;
var styleText = scatterStyle.styleText;

module.exports = function style(gd, calcTrace) {
if(calcTrace) styleTrace(gd, calcTrace);
Expand All @@ -25,6 +27,7 @@ function styleTrace(gd, calcTrace) {
s.style('opacity', calcTrace[0].trace.opacity);

stylePoints(s, trace, gd);
styleText(s, trace, gd);

// this part is incompatible with Drawing.lineGroupStyle
s.selectAll('path.js-line')
Expand Down
0