8000 Add `polar.hole` by etpinard · Pull Request #2977 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Add polar.hole #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 10, 2018
Merged

Add polar.hole #2977

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
39b2ee3
place <g.barlayer> below <g.scatterlayer> in polar subplot
etpinard Sep 6, 2018
ea7fd2c
add polar.hole
etpinard Sep 6, 2018
f547692
add a few TODO comments related to polar.hole
etpinard Sep 6, 2018
35199c6
make mock cartesian scale computation marginally simpler
etpinard Sep 7, 2018
8e5833d
cover a few more cases in polar_hole.json
etpinard Sep 7, 2018
ea877ee
add hover tests with polar.hole>0
etpinard Sep 7, 2018
a859872
add info about polar.hole in setConvert jsdoc
etpinard Sep 7, 2018
776e292
modif polar_hole mock to "see" axis line/tick ordering
etpinard Sep 7, 2018
9c3dcef
draw polar axis ticks above axis lines
etpinard Sep 7, 2018
1122907
fix and :lock: maindrag when polar.hole>0
etpinard Sep 7, 2018
d466146
add 'inner' radial dragbox when polar.hole>0
etpinard Sep 7, 2018
5a998a2
Merge branch 'master' into polar-hole
etpinard Sep 10, 2018
092006a
add 'inner' radial dragbox to all polar subplots
etpinard Sep 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add info about polar.hole in setConvert jsdoc
  • Loading branch information
@etpinard
etpinard committed Sep 7, 2018
commit a8598721c6fd0e8921ef5c83332a2189a7dc56c1
2 changes: 1 addition & 1 deletion src/plots/polar/set_convert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ var rad2deg = Lib.rad2deg;
*
* Radial axis coordinate systems:
* - d, c and l: same as for cartesian axes
* - g: like calcdata but translated about `radialaxis.range[0]`
* - g: like calcdata but translated about `radialaxis.range[0]` & `polar.hole`
*
* Angular axis coordinate systems:
* - d: data, in whatever form it's provided
Expand Down
0