8000 A slightly less ambitious take on orphan subplots and 'delete last trace' by etpinard · Pull Request #289 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

A slightly less ambitious take on orphan subplots and 'delete last trace' #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Feb 29, 2016
Merged

A slightly less ambitious take on orphan subplots and 'delete last trace' #289

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c4973f5
make Plotly.deleteTraces on 'surface' and 'mesh' traces work
etpinard Feb 19, 2016
48c6dfb
rm unnecessary hasCartesian check
etpinard Feb 19, 2016
1d4f7e6
make removing geo trace work:
etpinard Feb 19, 2016
fd5cab7
add geo and cartesian delete traces tests
etpinard Feb 19, 2016
d9ed496
generalize cleanScenes step:
etpinard Feb 19, 2016
26218f6
lint
etpinard Feb 23, 2016
e3cb6eb
write promise sequence as promise chains
etpinard Feb 22, 2016
1d2d9c3
assure that re-plots changing subplots pass through make framework
etpinard Feb 23, 2016
3a68023
assure that clearing cartesian axes in relayout lead to a re-calc
etpinard Feb 23, 2016
73817cb
add tests checking axis ranges after partial deletion
etpinard Feb 23, 2016
c75d8a2
add cartesian clean plot step to remove old pie traces
etpinard Feb 23, 2016
0d38cf7
rename Plots getSubplotIdsInData -> findSubplotIds
etpinard Feb 26, 2016
9da84df
standardize gl3d and geo layout default logic
etpinard Feb 26, 2016
07ca162
ensure that Plots getSubplotIds return ordered arrays of ids
etpinard Feb 26, 2016
ada31b5
robustify 'find axis' logic:
etpinard Feb 26, 2016
a71efa7
add jsdoc
etpinard Feb 26, 2016
de38b67
update geo delete trace test:
etpinard Feb 26, 2016
07efdc7
add trace type restyle and delete trace gl3d tests
etpinard Feb 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
write promise sequence as promise chains
  • Loading branch information
@etpinard
etpinard committed Feb 26, 2016
commit e3cb6eb83d52b8c1869bef80deb5f82ae46d03d5
51 changes: 27 additions & 24 deletions test/jasmine/tests/geo_interact_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,12 @@ describe('Test geo interactions', function() {
expect(countTraces('scattergeo')).toBe(0);
expect(countTraces('choropleth')).toBe(1);

Plotly.restyle(gd, 'visible', true, [0]).then(function() {
expect(countTraces('scattergeo')).toBe(1);
expect(countTraces('choropleth')).toBe(1);
done();
});
return Plotly.restyle(gd, 'visible', true, [0]);
}).then(function() {
expect(countTraces('scattergeo')).toBe(1);
expect(countTraces('choropleth')).toBe(1);

done();
});
});

Expand All @@ -217,11 +218,12 @@ describe('Test geo interactions', function() {
expect(countTraces('scattergeo')).toBe(1);
expect(countTraces('choropleth')).toBe(0);

Plotly.restyle(gd, 'visible', true, [1]).then(function() {
expect(countTraces('scattergeo')).toBe(1);
expect(countTraces('choropleth')).toBe(1);
done();
});
return Plotly.restyle(gd, 'visible', true, [1]);
}).then(function() {
expect(countTraces('scattergeo')).toBe(1);
expect(countTraces('choropleth')).toBe(1);

done();
});
});

Expand All @@ -240,20 +242,21 @@ describe('Test geo interactions', function() {
expect(countGeos()).toBe(1);
expect(countColorBars()).toBe(1);

Plotly.deleteTraces(gd, [0]).then(function() {
expect(countTraces('scattergeo')).toBe(0);
expect(countTraces('choropleth')).toBe(0);
expect(countGeos()).toBe(1);
expect(countColorBars()).toBe(0);

Plotly.relayout(gd, 'geo', null).then(function() {
expect(countTraces('scattergeo')).toBe(0);
expect(countTraces('choropleth')).toBe(0);
expect(countGeos()).toBe(0);
expect(countColorBars()).toBe(0);
done();
});
});
return Plotly.deleteTraces(gd, [0]);
}).then(function() {
expect(countTraces('scattergeo')).toBe(0);
expect(countTraces('choropleth')).toBe(0);
expect(countGeos()).toBe(1);
expect(countColorBars()).toBe(0);

return Plotly.relayout(gd, 'geo', null);
}).then(function() {
expect(countTraces('scattergeo')).toBe(0);
expect(countTraces('choropleth')).toBe(0);
expect(countGeos()).toBe(0);
expect(countColorBars()).toBe(0);

done();
});
});
});
Expand Down
43 changes: 22 additions & 21 deletions test/jasmine/tests/plot_interact_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,27 +206,28 @@ describe('Test plot structure', function() {
assertContourNodes(2);
expect(countColorBars()).toEqual(0);

Plotly.deleteTraces(gd, [0]).then(function() {
expect(countSubplots()).toEqual(4);
assertHeatmapNodes(2);
assertContourNodes(2);
expect(countColorBars()).toEqual(0);

Plotly.deleteTraces(gd, [0]).then(function() {
expect(countSubplots()).toEqual(4);
assertHeatmapNodes(1);
assertContourNodes(1);
expect(countColorBars()).toEqual(0);

Plotly.deleteTraces(gd, [0]).then(function() {
expect(countSubplots()).toEqual(4);
assertHeatmapNodes(0);
assertContourNodes(0);
expect(countColorBars()).toEqual(0);
done();
});
});
});
return Plotly.deleteTraces(gd, [0]);
}).then(function() {
expect(countSubplots()).toEqual(4);
assertHeatmapNodes(2);
assertContourNodes(2);
expect(countColorBars()).toEqual(0);

return Plotly.deleteTraces(gd, [0]);
}).then(function() {
expect(countSubplots()).toEqual(4);
assertHeatmapNodes(1);
assertContourNodes(1);
expect(countColorBars()).toEqual(0);

return Plotly.deleteTraces(gd, [0]);
}).then(function() {
expect(countSubplots()).toEqual(4);
assertHeatmapNodes(0);
assertContourNodes(0);
expect(countColorBars()).toEqual(0);

done();
});
});

Expand Down
0