8000 Faster trace visibility toggling by etpinard · Pull Request #2837 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content
8000

Faster trace visibility toggling #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Faster trace visibility toggling #2837

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e85725a
cleanup in scattergl sceneUpdate & plot
etpinard Jul 23, 2018
1675047
swap visible editType 'calc' -> 'plot'
etpinard Jul 19, 2018
3790734
push trace module into fullLayout._modules even if visible:false
etpinard Jul 23, 2018
cf65abd
use trace.uid-based visible batch array
etpinard Jul 23, 2018
b816a8e
fill in list of visible:true module in fullLayout._visibleModules
etpinard Jul 23, 2018
25ed567
fix and :lock: splom trace visible toggling
etpinard Jul 23, 2018
1f61ff0
adapt scatterpolargl for scene.visibleBatch
etpinard Jul 23, 2018
f1f06f4
add a few comments
etpinard Jul 23, 2018
4af6528
adapt and improve scattergl visible toggle tests
etpinard Jul 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump 8000 to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
push trace module into fullLayout._modules even if visible:false 
- so that gl-based trace can call their plot methods w/ an
  empty array of traces and just work.
- this makes restyle(gd, 'visible', false) work properly for
  scattergl traces
  • Loading branch information
@etpinard
etpinard committed Jul 23, 2018
commit 3790734abdf0c6c37f1864cba726ed2493820376
4 changes: 2 additions & 2 deletions src/plots/plots.js
View file
Open in des 8CCA ktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ plots._hasPlotType = function(category) {
if(basePlotModules[i].name === category) return true;
}

// check trace modules
// check trace modules (including non-visible:true)
var modules = this._modules || [];
for(i = 0; i < modules.length; i++) {
var name = modules[i].name;
Expand Down Expand Up @@ -912,7 +912,7 @@ plots.supplyDataDefaults = function(dataIn, dataOut, layout, fullLayout) {
var _module = fullTrace._module;
if(!_module) return;

if(fullTrace.visible === true) Lib.pushUnique(modules, _module);
Lib.pushUnique(modules, _module);
Lib.pushUnique(basePlotModules, fullTrace._module.basePlotModule);

cnt++;
Expand Down
0