8000 Sanitize orphan subplot logic and 'last trace' deletion by etpinard · Pull Request #268 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Sanitize orphan subplot logic and 'last trace' deletion #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Sanitize orphan subplot logic and 'last trace' deletion #268

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3198229
make Plotly.deleteTraces on 'surface' and 'mesh' traces work
etpinard Feb 19, 2016
4def847
replace getSubplotIdsInData by findSubplotIds:
etpinard Feb 19, 2016
464f761
robustify 'find axes' logic:
etpinard Feb 19, 2016
a289fd6
use findSubplotIds in gl3d and geo defaults steps:
etpinard Feb 19, 2016
41a2a8d
rm unnecessary hasCartesian check
etpinard Feb 19, 2016
ef7f501
ensure that Plots.getSubplotIds returns an ordered list of ids
etpinard Feb 19, 2016
0a6991e
make removing geo trace work:
etpinard Feb 19, 2016
b7f9471
generalize cleanScenes step:
etpinard Feb 19, 2016
6ea30d5
add geo and cartesian delete traces tests
etpinard Feb 19, 2016
2a32131
add blank plot types test mock
etpinard Feb 19, 2016
f3e1c2b
lint
etpinard Feb 19, 2016
dc72d33
fix typos
etpinard Feb 22, 2016
bf6793e
write promise sequence as promise chains
etpinard Feb 22, 2016
09de224
lint
etpinard Feb 23, 2016
a2f2ce8
assure that re-plots changing subplots pass through make framework
etpinard Feb 23, 2016
ba6eeea
assure that clearing cartesian axes in relayout lead to a re-calc
etpinard Feb 23, 2016
8fac52d
Merge branch 'master' into delete-last-trace
etpinard Feb 23, 2016
1de0d19
add tests checking axis ranges after partial deletion
etpinard Feb 23, 2016
245f8a4
add cartesian clean plot step to remove old pie traces
etpinard Feb 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ensure that Plots.getSubplotIds returns an ordered list of ids
  • Loading branch information
@etpinard
etpinard committed Feb 19, 2016
commit ef7f50120788d9ee0273b5161c37989ae1d0bc09
31 changes: 23 additions & 8 deletions src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,19 @@ plots.findSubplotIds = function findSubplotIds(data, layout, type) {
return subplotIds;
};

/**
* Get the ids of the current subplots.
*
* @param {object} layout plotly full layout object.
* @param {string} type subplot type to look for.
*
* @return {array} list of ordered subplot ids (strings).
*
*/
plots.getSubplotIds = function getSubplotIds(layout, type) {
if(plots.subplotsRegistry[type] === undefined) return [];
var _module = plots.subplotsRegistry[type];

if(_module === undefined) return [];

// layout must be 'fullLayout' here
if(type === 'cartesian' && !layout._hasCartesian) return [];
Expand All @@ -196,19 +207,23 @@ plots.getSubplotIds = function getSubplotIds(layout, type) {
return Object.keys(layout._plots);
}

var idRegex = plots.subplotsRegistry[type].idRegex,
var idRegex = _module.idRegex,
layoutKeys = Object.keys(layout),
subplotIds = [],
layoutKey;
subplotIds = [];

for(var i = 0; i < layoutKeys.length; i++) {
layoutKey = layoutKeys[i];
var layoutKey = layoutKeys[i];

if(idRegex.test(layoutKey)) subplotIds.push(layoutKey);
}

return subplotIds;
};

// order the ids
var idLen = _module.idRoot.length;
subplotIds.sort(function(a, b) {
var aNum = +(a.substr(idLen) || 1),
bNum = +(b.substr(idLen) || 1);
return aNum - bNum;
});

return subplotIds;
};
Expand Down
28 changes: 23 additions & 5 deletions test/jasmine/tests/plots_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,11 @@ describe('Test Plots', function() {

describe('Plots.getSubplotIds', function() {
var getSubplotIds = Plots.getSubplotIds;
var layout;

it('returns scene ids', function() {
layout = {
scene: {},
it('returns scene ids in order', function() {
var layout = {
scene2: {},
scene: {},
scene3: {}
};

Expand All @@ -116,13 +115,32 @@ describe('Test Plots', function() {

expect(getSubplotIds(layout, 'cartesian'))
.toEqual([]);
expect(getSubplotIds(layout, 'geo'))
.toEqual([]);
expect(getSubplotIds(layout, 'no-valid-subplot-type'))
.toEqual([]);
});

it('returns geo ids in order', function() {
var layout = {
geo2: {},
geo: {},
geo3: {}
};

expect(getSubplotIds(layout, 'geo'))
.toEqual(['geo', 'geo2', 'geo3']);

expect(getSubplotIds(layout, 'cartesian'))
.toEqual([]);
expect(getSubplotIds(layout, 'gl3d'))
.toEqual([]);
expect(getSubplotIds(layout, 'no-valid-subplot-type'))
.toEqual([]);
});

it('returns cartesian ids', function() {
layout = {
var layout = {
_plots: { xy: {}, x2y2: {} }
};

Expand Down
0