8000 Fix relayout constrained axes + various multi-subplot perf improvements by etpinard · Pull Request #2628 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Fix relayout constrained axes + various multi-subplot perf improvements #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 14, 2018
Merged

Fix relayout constrained axes + various multi-subplot perf improvements #2628

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a12a22b
fix "axrange" edit under axis constraint
etpinard May 10, 2018
23964ca
rm doAutoRangeAndConstraints step from "axrange" edits
etpinard May 10, 2018
abd4bcf
move axis range/autorange/domain regex to module scope
etpinard May 10, 2018
09d5dd0
skip Axes.makeClipPaths under hasOnlyLargeSploms regime
etpinard May 10, 2018
5557d7b
resolves #2547 - target altered axes only on "axrange" edits
etpinard May 10, 2018
73b354b
only grab 2d axes in lsInner
etpinard May 11, 2018
e69b7dd
mv find-main-subplot logic from supplyDefaults -> lsInner
etpinard May 11, 2018
c947b2c
only override grid.(x|y)side default for sploms w/o lower half
etpinard May 11, 2018
6fa8ffd
update splom baselines
etpinard May 11, 2018
455ff4d
update splom_ragged-via-axes baseline
etpinard May 11, 2018
72b6558
split doTicks into multi-axes and doTicksSingle parts
etpinard May 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move axis range/autorange/domain regex to module scope
  • Loading branch information
@etpinard
etpinard committed May 10, 2018
commit abd4bcf669a672764dfbb812a47ce5274d9e322d
10 changes: 7 additions & 3 deletions src/plot_api/plot_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1721,6 +1721,10 @@ exports.relayout = function relayout(gd, astr, val) {
});
};

var AX_RANGE_RE = /^[xyz]axis[0-9]*\.range(\[[0|1]\])?$/;
var AX_AUTORANGE_RE = /^[xyz]axis[0-9]*\.autorange$/;
var AX_DOMAIN_RE = /^[xyz]axis[0-9]*\.domain(\[[0|1]\])?$/;

function _relayout(gd, aobj) {
var layout = gd.layout,
fullLayout = gd._fullLayout,
Expand Down Expand Up @@ -1834,11 +1838,11 @@ function _relayout(gd, aobj) {
fullLayout[ai] = gd._initialAutoSize[ai];
}
// check autorange vs range
else if(pleafPlus.match(/^[xyz]axis[0-9]*\.range(\[[0|1]\])?$/)) {
else if(pleafPlus.match(AX_RANGE_RE)) {
recordAlteredAxis(pleafPlus);
Lib.nestedProperty(fullLayout, ptrunk + '._inputRange').set(null);
}
else if(pleafPlus.match(/^[xyz]axis[0-9]*\.autorange$/)) {
else if(pleafPlus.match(AX_AUTORANGE_RE)) {
recordAlteredAxis(pleafPlus);
Lib.nestedProperty(fullLayout, ptrunk + '._inputRange').set(null);
var axFull = Lib.nestedProperty(fullLayout, ptrunk).get();
Expand All @@ -1848,7 +1852,7 @@ function _relayout(gd, aobj) {
axFull._input.domain = axFull._inputDomain.slice();
}
}
else if(pleafPlus.match(/^[xyz]axis[0-9]*\.domain(\[[0|1]\])?$/)) {
else if(pleafPlus.match(AX_DOMAIN_RE)) {
Lib.nestedProperty(fullLayout, ptrunk + '._inputDomain').set(null);
}

Expand Down
0