Switching to relayouting for plotdrag and gl3d rotations.

plotly · zhihua-chen · May 3, 2018 · May 28, 2018 · May 28, 2018 · May 28, 2018
commit 2f0d6332aadba4a4f72b301fbd6a5e0fe825a859
diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js
@@ -527,7 +527,7 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
             updateSubplots([xActive ? -dx : 0, yActive ? -dy : 0, pw, ph]);
             ticksAndAnnotations(yActive, xActive);
             // updates computed in ticksAndAnnotations
-            gd.emit('plotly_relayout', updates);
+            gd.emit('plotly_relayouting', updates);
             return;
         }
 
@@ -601,7 +601,7 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
         updateSubplots([x0, y0, pw - dx, ph - dy]);
         ticksAndAnnotations(yActive, xActive);
         // updates computed in ticksAndAnnotations
-        gd.emit('plotly_relayout', updates);
+        gd.emit('plotly_relayouting', updates);
     }
 
     // Draw ticks and annotations (and other components) when ranges change.

diff --git a/src/plots/gl3d/scene.js b/src/plots/gl3d/scene.js
@@ -215,7 +215,16 @@ function initializeGLPlot(scene, fullLayout, canvas, gl) {
         scene.saveCamera(scene.graphDiv.layout);
         scene.graphDiv.emit('plotly_relayout', update);
     };
-    scene.glplot.canvas.addEventListener('mousemove', relayoutCallback.bind(null, scene));
+    var relayoutingCallback = function(scene) {
+        if(scene.fullSceneLayout.dragmode === false) return;
+        var update = {};
+        update[scene.id + '.camera'] = getLayoutCamera(scene.camera);
+        // scene.saveCamera(scene.graphDiv.layout);
+        scene.graphDiv.emit('plotly_relayouting', update);
+    };
+
+    scene.glplot.canvas.addEventListener('mousemove', relayoutingCallback.bind(null, scene));
+    scene.glplot.canvas.addEventListener('mouseup', relayoutCallback.bind(null, scene));
     scene.glplot.canvas.addEventListener('wheel', relayoutCallback.bind(null, scene), passiveSupported ? {passive: false} : false);
 
     if(!scene.staticMode) {