fix finance tests - with a couple of bugfixes too

plotly · alexcjohnson · Apr 17, 2018 · Apr 5, 2018 · Apr 6, 2018 · Apr 10, 2018
commit 4c46a73d0851ebbf262d462485670e51f46de114
diff --git a/src/lib/coerce.js b/src/lib/coerce.js
@@ -433,9 +433,7 @@ exports.coerceFont = function(coerce, attr, dfltObj) {
  */
 exports.coerceHoverinfo = function(traceIn, traceOut, layoutOut) {
     var moduleAttrs = traceOut._module.attributes;
-    var attrs = moduleAttrs.hoverinfo ?
-        {hoverinfo: moduleAttrs.hoverinfo} :
-        baseTraceAttrs;
+    var attrs = moduleAttrs.hoverinfo ? moduleAttrs : baseTraceAttrs;
 
     var valObj = attrs.hoverinfo;
     var dflt;

diff --git a/src/traces/ohlc/calc.js b/src/traces/ohlc/calc.js
@@ -59,6 +59,7 @@ function calcCommon(gd, trace, x, ya, ptFunc) {
 
     // we're optimists - before we have any changing data, assume increasing
     var increasing = true;
+    var cPrev = null;
 
     var cd = [];
     for(var i = 0; i < x.length; i++) {
@@ -69,8 +70,14 @@ function calcCommon(gd, trace, x, ya, ptFunc) {
         var ci = c[i];
 
         if(xi !== undefined && oi !== undefined && hi !== undefined && li !== undefined && ci !== undefined) {
-            // increasing carries over from previous if ci===oi
-            increasing = (ci === oi) ? increasing : ci > oi;
+            if(ci === oi) {
+                // if open == close, look for a change from the previous close
+                if(cPrev !== null && ci !== cPrev) increasing = ci > cPrev;
+                // else (c === cPrev or cPrev is null) no change
+            }
+            else increasing = ci > oi;
+
+            cPrev = ci;
 
             var pt = ptFunc(oi, hi, li, ci);
 

diff --git a/src/traces/ohlc/hover.js b/src/traces/ohlc/hover.js
@@ -25,6 +25,10 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode) {
     var trace = cd[0].trace;
     var t = cd[0].t;
 
+    var type = trace.type;
+    var minAttr = type === 'ohlc' ? 'l' : 'min';
+    var maxAttr = type === 'ohlc' ? 'h' : 'max';
+
     // potentially shift xval for grouped candlesticks
     var centerShift = t.bPos || 0;
     var x0 = xval - centerShift;
@@ -44,7 +48,7 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode) {
     }
 
     function dy(di) {
-        return Fx.inbox(di.min - yval, di.max - yval, hoverPseudoDistance);
+        return Fx.inbox(di[minAttr] - yval, di[maxAttr] - yval, hoverPseudoDistance);
     }
 
     function dxy(di) { return (dx(di) + dy(di)) / 2; }