8000 Splom zoom perf by etpinard · Pull Request #2527 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Splom zoom perf #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 11, 2018
Merged

Splom zoom perf #2527

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
02ed2eb
move doAutoRangeAndConstraints, drawData and finalDraw to subroutines
etpinard Apr 5, 2018
3ad1eaa
add 'axrange' editType
etpinard Apr 5, 2018
bb02281
speed up doModeBar subroutines for cartesian subplots
etpinard Apr 5, 2018
d07ae70
improve fullLayout._has()
etpinard Apr 5, 2018
468119e
speed up dragbox
etpinard Apr 5, 2018
0979272
clean splom drag logic
etpinard Apr 5, 2018
ebb35ce
lint in plot_api
etpinard Apr 5, 2018
f9090b7
(fixup) add draggedPts to scattercarpet categories
etpinard Apr 6, 2018
b2ee736
Merge branch 'splom-feature' into splom-zoom-perf
etpinard Apr 9, 2018
a0b2574
Merge branch 'splom-feature' into splom-zoom-perf
etpinard Apr 9, 2018
d3fe40d
replace selectAll with for(k in _plots) loop
etpinard Apr 10, 2018
cc1b3de
fixup and :lock: dragbox with linked y axes
etpinard Apr 10, 2018
980855c
Merge branch 'splom-feature' into splom-zoom-perf
etpinard Apr 11, 2018
f7d637d
:books: link TODOs to gh issues
etpinard Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'splom-feature' into splom-zoom-perf
  • Loading branch information
@etpinard
etpinard committed Apr 9, 2018
commit b2ee73693036ab189f97aa676bf78570cfae9c74
16 changes: 10 additions & 6 deletions src/traces/splom/base_plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ function drag(gd) {
var scene = cd0.t._scene;

if(trace.type === 'splom' && scene && scene.matrix) {
var activeLength = trace._activeLength;
var visibleLength = scene.matrixOptions.data.length;
var ranges = new Array(visibleLength);
var k = 0;
dragOne(gd, trace, scene);
}
}
}

function dragOne(gd, trace, scene) {
var dimensions = trace.dimensions;
Expand All @@ -77,8 +77,12 @@ function dragOne(gd, trace, scene) {
}
}

if(fullLayout._hasOnlyLargeSploms) {
drawGrid(gd);
if(scene.selectBatch) {
scene.matrix.update({ranges: ranges}, {ranges: ranges});
scene.matrix.draw(scene.unselectBatch, scene.selectBatch);
} else {
scene.matrix.update({ranges: ranges});
scene.matrix.draw();
}
}

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
0