first pass splom basePlotModule clean step

... the destroy method for regl-scattermatrix instance is broken, see gl-vis/regl-splom#3
plotly · etpinard · Apr 16, 2018 · Mar 12, 2018 · Mar 28, 2018 · Mar 28, 2018
commit 0fb65ddbd04dd2e45a663b2ca2d138c36e3db8f6
diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js
@@ -666,7 +666,7 @@ exports.newPlot = function(gd, data, layout, config) {
     gd = Lib.getGraphDiv(gd);
 
     // remove gl contexts
-    Plots.cleanPlot([], {}, gd._fullData || {}, gd._fullLayout || {});
+    Plots.cleanPlot([], {}, gd._fullData || {}, gd._fullLayout || {}, gd.calcdata || []);
 
     Plots.purge(gd);
     return exports.plot(gd, data, layout, config);
@@ -3234,11 +3234,12 @@ exports.deleteFrames = function(gd, frameList) {
 exports.purge = function purge(gd) {
     gd = Lib.getGraphDiv(gd);
 
-    var fullLayout = gd._fullLayout || {},
-        fullData = gd._fullData || [];
+    var fullLayout = gd._fullLayout || {};
+    var fullData = gd._fullData || [];
+    var calcdata = gd.calcdata || [];
 
     // remove gl contexts
-    Plots.cleanPlot([], {}, fullData, fullLayout);
+    Plots.cleanPlot([], {}, fullData, fullLayout, calcdata);
 
     // purge properties
     Plots.purge(gd);

diff --git a/src/plots/plots.js b/src/plots/plots.js
@@ -287,6 +287,8 @@ plots.supplyDefaults = function(gd) {
     var newFullData = gd._fullData = [];
     var newData = gd.data || [];
 
+    var oldCalcdata = gd.calcdata || [];
+
     var context = gd._context || {};
 
     var i, j;
@@ -428,7 +430,7 @@ plots.supplyDefaults = function(gd) {
     newFullLayout._hasPie = newFullLayout._has('pie');
 
     // clean subplots and other artifacts from previous plot calls
-    plots.cleanPlot(newFullData, newFullLayout, oldFullData, oldFullLayout);
+    plots.cleanPlot(newFullData, newFullLayout, oldFullData, oldFullLayout, oldCalcdata);
 
     // relink / initialize subplot axis objects
     plots.linkSubplots(newFullData, newFullLayout, oldFullData, oldFullLayout);
@@ -447,10 +449,10 @@ plots.supplyDefaults = function(gd) {
     }
 
     // update object references in calcdata
-    if((gd.calcdata || []).length === newFullData.length) {
+    if(oldCalcdata === newFullData.length) {
         for(i = 0; i < newFullData.length; i++) {
             var newTrace = newFullData[i];
-            var cd0 = gd.calcdata[i][0];
+            var cd0 = oldCalcdata[i][0];
             if(cd0 && cd0.trace) {
                 if(cd0.trace._hasCalcTransform) {
                     remapTransformedArrays(cd0, newTrace);
@@ -648,15 +650,15 @@ plots._hasPlotType = function(category) {
     return false;
 };
 
-plots.cleanPlot = function(newFullData, newFullLayout, oldFullData, oldFullLayout) {
+plots.cleanPlot = function(newFullData, newFullLayout, oldFullData, oldFullLayout, oldCalcdata) {
     var i, j;
 
     var basePlotModules = oldFullLayout._basePlotModules || [];
     for(i = 0; i < basePlotModules.length; i++) {
         var _module = basePlotModules[i];
 
         if(_module.clean) {
-            _module.clean(newFullData, newFullLayout, oldFullData, oldFullLayout);
+            _module.clean(newFullData, newFullLayout, oldFullData, oldFullLayout, oldCalcdata);
         }
     }
 

diff --git a/src/traces/splom/base_plot.js b/src/traces/splom/base_plot.js
@@ -186,9 +186,43 @@ function showZeroLine(ax) {
     );
 }
 
-function clean(newFullData, newFullLayout, oldFullData, oldFullLayout) {
-    // TODO clear regl-splom instances
-    // TODO clear regl-line2d grid instance!
+function clean(newFullData, newFullLayout, oldFullData, oldFullLayout, oldCalcdata) {
+    var oldModules = oldFullLayout._modules || [];
+    var newModules = newFullLayout._modules || [];
+
+    var hadSplom, hasSplom;
+    var i;
+
+    for(i = 0; i < oldModules.length; i++) {
+        if(oldModules[i].name === 'splom') {
+            hadSplom = true;
+            break;
+        }
+    }
+    for(i = 0; i < newModules.length; i++) {
+        if(newModules[i].name === 'splom') {
+            hasSplom = true;
+            break;
+        }
+    }
+
+    if(hadSplom && !hasSplom) {
+        for(i = 0; i < oldCalcdata.length; i++) {
+            var cd0 = oldCalcdata[i][0];
+            var trace = cd0.trace;
+            var scene = cd0.t._scene;
+
+            if(trace.type === 'splom' && scene && scene.matrix) {
+                // this below throws as error
+                // scene.matrix.destroy();
+            }
+        }
+    }
+
+    if(oldFullLayout._splomGrid &&
+        (!newFullLayout._hasOnlyLargeSploms && oldFullLayout._hasOnlyLargeSploms)) {
+        oldFullLayout._splomGrid.destroy();
+    }
 
     Cartesian.clean(newFullData, newFullLayout, oldFullData, oldFullLayout);
 }