8000 Relink less stuff by alexcjohnson · Pull Request #2375 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Relink less stuff #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 16, 2018
Merged

Relink less stuff #2375

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95d540e
don't relink customdata, ids, or any matching objects
alexcjohnson Feb 16, 2018
1723ed8
update style in relinkPrivateKeys
alexcjohnson Feb 16, 2018
3e22d38
mock out createObjectURL for makeSchema task
alexcjohnson Feb 16, 2018
5a3d2a6
tighten array handling in relinkPrivateKeys
alexcjohnson Feb 16, 2018
62e54b7
comment about making `ids` be strings only
alexcjohnson Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update style in relinkPrivateKeys
  • Loading branch information
@alexcjohnson
alexcjohnson committed Feb 16, 2018
commit 1723ed80491e4f510bef2f6f536b91f685a2bc2d
9 changes: 3 additions & 6 deletions src/lib/relink_private.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,9 @@ var isPlainObject = require('./is_plain_object');
* This prevents deepCopying massive structures like a webgl context.
*/
module.exports = function relinkPrivateKeys(toContainer, fromContainer) {
var keys = Object.keys(fromContainer || {});

for(var i = 0; i < keys.length; i++) {
var k = keys[i],
fromVal = fromContainer[k],
toVal = toContainer[k];
for(var k in fromContainer) {
var fromVal = fromContainer[k];
var toVal = toContainer[k];

if(toVal === fromVal) {
continue;
Expand Down
0