10000 fix ghost fill-tonext when either trace is emptied out by alexcjohnson · Pull Request #2280 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

fix ghost fill-tonext when either trace is emptied out #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact it 8000 s maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2018
Merged

fix ghost fill-tonext when either trace is emptied out #2280

merged 1 commit into from
Jan 23, 2018

Conversation

alexcjohnson
Copy link
Collaborator

Fixes #2271 - we were short-circuiting a little too much behavior when no line is generated by a trace.

@dfcreative another quick one to look at, if you would!

@alexcjohnson alexcjohnson mentioned this pull request Jan 23, 2018
Closed
@dy
Copy link
Contributor
dy commented Jan 23, 2018

Turns out this test case does not work with scattergl, although it should, I should have a look.
Also is that correct that the legend shows an empty trace?
image
In all looks good!

@alexcjohnson
Copy link
Collaborator Author

is that correct that the legend shows an empty trace?

Yes, trace 1 has mode: 'lines', line: {width: 0}, rendering it invisible (could have just done mode: 'none' like trace 2 but without the fill, but this works too)

@dy
Copy link
Contributor
dy commented Jan 23, 2018

💃 :)

@alexcjohnson alexcjohnson merged commit 536ba6f into master Jan 23, 2018
@alexcjohnson alexcjohnson deleted the ghost-fill branch January 23, 2018 18:49
@dy dy mentioned this pull request Jan 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcjohnson @dy
0