8000 Fix scattergl selection by dy · Pull Request #2267 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Fix scattergl selection #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dy wants to merge 8 commits into from
Closed

Fix scattergl selection #2267

dy wants to merge 8 commits into from

Conversation

@dy
Copy link
Contributor
@dy dy commented Jan 19, 2018

Fixes #2266

@dy dy mentioned this pull request Jan 19, 2018
Closed
@alexcjohnson
Copy link
Collaborator
alexcjohnson commented Jan 19, 2018

Thanks @dfcreative - is there a test we can add that shows that this fixes the bug?

@chriddyp chriddyp mentioned this pull request Jan 22, 2018
Merged
@dy
Copy link
Contributor Author
dy commented Jan 22, 2018

@alexcjohnson added selection test at 348d4d0

alexcjohnson
alexcjohnson reviewed Jan 22, 2018
View reviewed changes
test/jasmine/tests/gl_plot_interact_test.js Outdated
var x = [], y = [];
for(var i = 0; i < 2e4; i++) {
x.push(Math.random());
y.push(Math.random());
Copy link
Collaborator
@alexcjohnson alexcjohnson Jan 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's probably an infinitesimal chance that this will cause any problems, but I still don't like having random calls in a test suite. If you really want something random-looking, as opposed to some simple formula, consider appropriating something reproducible like we used for box plot jitter

Copy link
Contributor Author
@dy dy Jan 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alexcjohnson! Fixed in 39be256

@alexcjohnson
Copy link
Collaborator
alexcjohnson commented Jan 22, 2018

Beautiful, thanks! 💃

@jackparmer
Copy link
Contributor
jackparmer commented Jan 22, 2018

cc @cpsievert

@alexcjohnson alexcjohnson mentioned this pull request Jan 22, 2018
Closed
@dy
Copy link
Contributor Author
dy commented Jan 23, 2018

Closed by cb2729e

@dy dy closed this Jan 23, 2018
@dy dy deleted the reglscatter-fix branch January 23, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnson alexcjohnson alexcjohnson left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dy @alexcjohnson @jackparmer
0