8000 Transform inverse mapping by monfera · Pull Request #2126 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Transform inverse mapping #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 27, 2017
Merged

Transform inverse mapping #2126

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1ddbd93
inverse mapping
monfera Oct 25, 2017
e1589bc
removing unused attributes
monfera Oct 26, 2017
caf707e
working, cascading filter transform points
monfera Oct 26, 2017
979ddea
filter points cascading simplification
monfera Oct 26, 2017
fb9b049
test for heterogeneous transforms
monfera Oct 26, 2017
039d9b6
aggregation to also use points from the preceding `transform` step
monfera Oct 26, 2017
70a0f68
rename to _indexToPoints
monfera Oct 27, 2017
ce3a118
extracting out common function
monfera Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing unused attributes
  • Loading branch information
@monfera
monfera committed Oct 26, 2017
commit e1589bce70da7bd763ded704c7f2b4422029b5ee
3 changes: 0 additions & 3 deletions src/transforms/aggregate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,6 @@ exports.calcTransform = function(gd, trace, opts) {
var i, vi, groupIndex, newGrouping;

var groupIndices = {};
var groupToPoints = {};
var indexToPoints = {};
var groupings = [];
for(i = 0; i < groupArray.length; i++) {
Expand All @@ -228,13 +227,11 @@ exports.calcTransform = function(gd, trace, opts) {
groupIndices[vi] = groupings.length;
newGrouping = [i];
groupings.push(newGrouping);
groupToPoints[vi] = newGrouping;
indexToPoints[groupIndices[vi]] = newGrouping;
}
else groupings[groupIndex].push(i);
}

opts.groupToPoints = groupToPoints;
opts.indexToPoints = indexToPoints;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this isn't a real attribute but we're putting it back into fullData lets give it an _ - ie opts._indexToPoints.


var aggregations = opts.aggregations;
Expand Down
0