8000 Branch for 1.31.2 by etpinard · Pull Request #2111 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Branch for 1.31.2 #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 23, 2017
Merged

Branch for 1.31.2 #2111

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
af0f4fd
fix #2088 - with tests!
alexcjohnson Oct 16, 2017
9300a74
update find_all_paths syntax
alexcjohnson Oct 16, 2017
96d0c0e
fix double-merge portion of contour algo - and move the test to an im…
alexcjohnson Oct 17, 2017
ca3b4f4
handle trace with no points, resulting in invisible trace and node3 u…
monfera Oct 18, 2017
c227992
test: handle trace with no points, resulting in invisible trace and n…
monfera Oct 18, 2017
9b77f9f
more upstream fix for avoiding invisible traces
monfera Oct 18, 2017
ea9880e
discontinuing per-trace type visibility check
monfera Oct 18, 2017
12b0e02
moving check more upstream
monfera Oct 18, 2017
6b44d39
fixup choropleth select test
etpinard Oct 20, 2017
acf9f31
adding table_test.js
monfera Oct 19, 2017
805aa06
fix for non-removed columns and zero row counts
monfera Oct 19, 2017
3f73dcc
making default cell row heights the same as header row height
monfera Oct 19, 2017
3d56195
ensuring special cases 0 rows or 0 columns work; noOpacity
monfera Oct 19, 2017
b6d83ca
deferring the cell height change for now
monfera Oct 19, 2017
859daeb
additional test case; minor renames
monfera Oct 20, 2017
c45f812
update changelog for 1.31.2
etpinard Oct 23, 2017
cc673fa
1.31.2
etpinard Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
discontinuing per-trace type visibility check
  • Loading branch information
@monfera @etpinard
monfera authored and etpinard committed Oct 23, 2017
commit ea9880efe07a2e906bc299721789937efe88d147
3 changes: 0 additions & 3 deletions src/traces/bar/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,9 @@ var DESELECTDIM = require('../../constants/interactions').DESELECTDIM;
module.exports = function selectPoints(searchInfo, polygon) {
var cd = searchInfo.cd;
var selection = [];
var trace = cd[0].trace;
var node3 = cd[0].node3;
var i;

if(trace.visible !== true) return [];

if(polygon === false) {
// clear selection
for(i = 0; i < cd.length; i++) {
Expand Down
2 changes: 1 addition & 1 deletion src/traces/scatter/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = function selectPoints(searchInfo, polygon) {

// TODO: include lines? that would require per-segment line properties
var hasOnlyLines = (!subtypes.hasMarkers(trace) && !subtypes.hasText(trace));
if(trace.visible !== true || hasOnlyLines) return [];
if(hasOnlyLines) return [];

var opacity = Array.isArray(marker.opacity) ? 1 : marker.opacity;

Expand Down
2 changes: 1 addition & 1 deletion src/traces/scattergeo/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = function selectPoints(searchInfo, polygon) {
var di, lonlat, x, y, i;

var hasOnlyLines = (!subtypes.hasMarkers(trace) && !subtypes.hasText(trace));
if(trace.visible !== true || hasOnlyLines) return [];
if(hasOnlyLines) return [];

var marker = trace.marker;
var opacity = Array.isArray(marker.opacity) ? 1 : marker.opacity;
Expand Down
D9FE
2 changes: 1 addition & 1 deletion src/traces/scattergl/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = function selectPoints(searchInfo, polygon) {
var scene = glTrace.scene;

var hasOnlyLines = (!subtypes.hasMarkers(trace) && !subtypes.hasText(trace));
if(trace.visible !== true || hasOnlyLines) return [];
if(hasOnlyLines) return [];

// filter out points by visible scatter ones
if(polygon === false) {
Expand Down
2 changes: 1 addition & 1 deletion src/traces/scattermapbox/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = function selectPoints(searchInfo, polygon) {
// to not insert data-driven 'circle-opacity' when we don't need to
trace._hasDimmedPts = false;

if(trace.visible !== true || !subtypes.hasMarkers(trace)) return [];
if(!subtypes.hasMarkers(trace)) return [];

if(polygon === false) {
for(i = 0; i < cd.length; i++) {
Expand Down
0