8000 Table view - squashed by monfera · Pull Request #2052 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Table view - squashed #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Oct 5, 2017
Merged

Table view - squashed #2052

Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
c4244db
table - initial commit (squashed feature branch)
monfera Oct 3, 2017
865e444
adding birds mock
monfera Oct 3, 2017
2648e51
minor mock change
monfera Oct 3, 2017
1922721
avoid crispEdges in cell contents and scrollbar; minor mock change
monfera Oct 3, 2017
30cbaa0
doc change
monfera Oct 3, 2017
aa0c116
fewer accessor uses
monfera Oct 3, 2017
c0ac213
doc update
monfera Oct 3, 2017
732bd46
more idiomatic D3
monfera Oct 3, 2017
22e23e3
no prefixing with window
monfera Oct 3, 2017
9571be3
amending document
monfera Oct 3, 2017
345b027
switched off bounciness
monfera Oct 3, 2017
ff3c8f6
minor mock fix
monfera Oct 3, 2017
b9c8de6
staying valign for the moment
monfera Oct 4, 2017
c1d19b4
fixes non-wrapping wrappable case by including it in the `alignment-b…
monfera Oct 4, 2017
f8e7647
mock update - showing text wrapping
monfera Oct 4, 2017
7186527
separate mock for wrapped text; fixing a scrolling issue
monfera Oct 4, 2017
e96c3c4
adding editType (for now, conservatively)
monfera Oct 4, 2017
5336725
new mock
monfera Oct 4, 2017
6f21697
adding multitrace latex mock; fixing multitrace drag bug
monfera Oct 4, 2017
f3f1a5d
fixing multitrace drag bug 2
monfera Oct 4, 2017
9574099
fixing multitrace drag bug 3
monfera Oct 4, 2017
5a59e04
fixing multitrace drag bug 4
monfera Oct 4, 2017
dd5841d
multitrace mock with scrollers to show trace independence
monfera Oct 4, 2017
9b60156
new mock: adding scatter plot to trace
monfera Oct 4, 2017
309c8bb
moving functionality from `calc.js` to a helper file
monfera Oct 4, 2017
78cb5ec
moving functionality from `plot.js` to the data split file
monfera Oct 4, 2017
b14f6c6
mock JSON consolidated to fewer items
monfera Oct 5, 2017
2be591f
removed clipView debug option
monfera Oct 5, 2017
addb85b
allow cell text selection
monfera Oct 5, 2017
c2f251f
fixing server image gen issue - thanks Étienne - and removing the pos…
monfera Oct 5, 2017
3cab51d
adding baselines
monfera Oct 5, 2017
fa84c68
globally safe clipPath #1
monfera Oct 5, 2017
465b45b
use overrideAll in table attributes
etpinard Oct 5, 2017
0fa1cc8
globally safe clipPath #2
monfera Oct 5, 2017
cd0578d
Merge branch 'table-squashed' of https://github.com/plotly/plotly.js …
monfera Oct 5, 2017
a6c4935
add baselines
etpinard Oct 5, 2017
0ad1a0c
preparing for user-specified stroke/stroke-opacity, fill/fill-opacity…
monfera Oct 5, 2017
1254c9f
user-specified stroke/stroke-opacity, fill/fill-opacity setting via C…
monfera Oct 5, 2017
e38b7cf
Merge branch 'table-squashed' of https://github.com/plotly/plotly.js …
monfera Oct 5, 2017
94338f4
Merge branch 'table-textselect' into table-squashed
monfera Oct 5, 2017
6288559
minor simplification before rewiring event handlers to enable text copy
monfera Oct 5, 2017
154ab24
allow both dragging and text cell copying
monfera Oct 5, 2017
9402020
disable visible scrollbar on initial load
monfera Oct 5, 2017
d4f0ed7
updating other mocks
monfera Oct 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc change
  • Loading branch information
@monfera
monfera committed Oct 3, 2017
commit 30cbaa02174c531c5f3312d433558021d5e4a4d6
12 changes: 6 additions & 6 deletions src/traces/table/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ module.exports = {
role: 'info',
dflt: [],
description: [
'Dimension values. `values[n]` represents the value of the `n`th point in the dataset,',
'therefore the `values` vector for all dimensions must be the same (longer vectors',
'will be truncated). Each value must be a finite number.'
'Header cell values. `values[m][n]` represents the value of the `n`th point in column `m`,',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so header values must be 2D too or just can be 2D?

What's the use case for multi-row headers? Wouldn't adding <br> suffice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, even header rows must be 2D. It'd make sense to allow the common 1D case, though adding it later doesn't break existing JSONs. It's 2D in small part due to code uniformity - header and content are handled by the same code path except stuff like no scrolling for header rows and acting as column drags.

But the more important part was a previous PR comment suggesting it, e.g. to have a 2nd row for units of measure.

A <br> would often but not always suffice. For example, top cell may be left-aligned text and bottom cell may be right-aligned LaTeX with another font size. Also, multirow header is implemented (took a bit of time) and causes no issues.

One more reason for this common-path implementation style was to eventually support other row groups, e.g. aggregate rows but that's just a concept now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. But please add a allow 1D header values items to #2056

'therefore the `values[m]` vector length for all columns must be the same (longer vectors',
'will be truncated). Each value must be a finite number or a string.'
].join(' ')
},

Expand Down Expand Up @@ -175,9 +175,9 @@ module.exports = {
role: 'info',
dflt: [],
description: [
'Dimension values. `values[n]` represents the value of the `n`th point in the dataset,',
'therefore the `values` vector for all dimensions must be the same (longer vectors',
'will be truncated). Each value must be a finite number.'
'Cell values. `values[m][n]` represents the value of the `n`th point in column `m`,',
'therefore the `values[m]` vector length for all columns must be the same (longer vectors',
'will be truncated). Each value must be a finite number or a string.'
].join(' ')
},

Expand Down
0