8000 Granular options for on-chart editing by alexcjohnson · Pull Request #1895 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Granular options for on-chart editing #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2017
Merged

Granular options for on-chart editing #1895

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5500120
forEach -> for
alexcjohnson Jul 18, 2017
9d4b191
DRY-up computeLegendDimensions
alexcjohnson Jul 18, 2017
b4e26ae
optionally split up editable into granular parts
alexcjohnson Jul 18, 2017
04d49dd
extendDeep for defaultConfig so we clone edits and don't modify it
alexcjohnson Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
extendDeep for defaultConfig so we clone edits and don't modify it
  • Loading branch information
@alexcjohnson
alexcjohnson committed Jul 18, 2017
commit 04d49dda3174b76b9388ed3c6b6d932a968e1430
2 changes: 1 addition & 1 deletion src/plot_api/plot_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ function opaqueSetBackground(gd, bgColor) {
}

function setPlotContext(gd, config) {
if(!gd._context) gd._context = Lib.extendFlat({}, Plotly.defaultConfig);
if(!gd._context) gd._context = Lib.extendDeep({}, Plotly.defaultConfig);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Maybe config isn't as poorly tested than I thought.

var context = gd._context;

var i, keys, key;
Expand Down
0