Scattermapbox BADNUM + mapbox-gl@0.33.1 #1543
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to improve performance in check downstream - add calc tests to scattergeo_test.js
- to determine if calcdata item should be skipped
- 🔪 scattermapbox/calc.js, reuse scattergeo/calc.js instead! - this makes calcdata items 1-1 with fullData coords (as all our other trace types) - Use identity function type in properties (available since 0.26.0) to replace brutal hack with `stops` 🎉
- no need for it anymore.
Merged
alexcjohnson
reviewed
Apr 3, 2017
| if(!Array.isArray(cd) || !cd[0]) { | ||
| cd = [{x: false, y: false, placeholder: true}]; | ||
| cd = [{x: false, y: false}]; |
There was a problem hiding this comment.
should we turn this into [{x: BADNUM, y: BADNUM}] or are we not quite ready for that yet?
There was a problem hiding this comment.
Good call. Let me try that!
|
This looks great! Really nice simplification. Lets get the |
|
Replaced by #1564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be merged in #1538 - fixing the test failures there.
In brief, this PR:
scattermapbox/calc.jsreusescattergeo/calc.js♻️placeholdermapbox-glto^0.33.1. Among a few interesting performance improvements, this new version allows use theidentityproperty function which 🔪 the hackystopslogic inscattermapbox/convert.js🎉Important
mapbox-gl@0.33.1does not get along with thenw.jsversion we use in our image test container (same as on the plot.ly image server) - see here for more details. This is probably a good time to bump thenw.jsversion. The latestnw.jsversion is0.21.4while we're still using0.12cc @bpostlethwaiteNote that I couldn't update
mapbox-glto their latest version (v0.34.0) because that version is currently broken in browserified bundles and that patch hasn't been published yet.