8000 Scattergeo BADNUM by etpinard · Pull Request #1538 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Scattergeo BADNUM #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 7, 2017
Merged

Scattergeo BADNUM #1538

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bfe0211
make scattergeo calcdata 1-1 with lon/lat items in fullData
etpinard Mar 30, 2017
18091e8
rm `placeholder` early exit in scattergeo hover routine
etpinard Mar 30, 2017
a705ed1
update geojson util calcTraceToLineCoords to use BADNUM
etpinard Mar 30, 2017
64cbf2f
flatten scattegeo_test.js
etpinard Mar 31, 2017
f84627d
set lonlat to [BADNUM, BADNUM] if lon OR lat is non-numeric
etpinard Mar 31, 2017
e85fba5
only need to check lonlat[0] === BADNUM
etpinard Mar 31, 2017
6a7e2a4
Merge branch 'master' into scattergeo-badnum
etpinard Apr 7, 2017
aec6248
make sure mapbox-gl canvas does not inherit left and top css
etpinard Apr 7, 2017
1abbd90
:hocho: scattermapbox/calc.js | :recycle: scattergeo/calc.js
etpinard Apr 7, 2017
3e64aa0
update scattermapbox convert & hover
etpinard Apr 7, 2017
785bade
update mapbox baselines
etpinard Apr 7, 2017
5c2393a
:hocho: last remaining signs of `placeholder` key in calcdata
etpinard Mar 31, 2017
b5cd573
replace false values with BADNUM in empty calcdata traces
etpinard Apr 7, 2017
248b760
Merge pull request #1564 from plotly/scattermapbox-badnum2
etpinard Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
replace false values with BADNUM in empty calcdata traces
  • Loading branch information
@etpinard
etpinard committed Apr 7, 2017
commit b5cd57308c60b584ba47ba93b35bb02efdd15418
3 changes: 2 additions & 1 deletion src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ var Plotly = require('../plotly');
var Registry = require('../registry');
var Lib = require('../lib');
var Color = require('../components/color');
var BADNUM = require('../constants/numerical').BADNUM;

var plots = module.exports = {};

Expand Down Expand Up @@ -2013,7 +2014,7 @@ plots.doCalcdata = function(gd, traces) {
// This ensures there is a calcdata item for every trace,
// even if cartesian logic doesn't handle it (for things like legends).
if(!Array.isArray(cd) || !cd[0]) {
cd = [{x: false, y: false}];
cd = [{x: BADNUM, y: BADNUM}];
}

// add the trace-wide properties to the first point,
Expand Down
0