8000 Axes ref cleanup by etpinard · Pull Request #1431 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Axes ref cleanup #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 2, 2017
Merged

Axes ref cleanup #1431

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1700908
add extra karma config
etpinard Feb 28, 2017
11073f2
replace for-each by for-loop in cartesian layout defaults
etpinard Feb 28, 2017
2289657
rm _gd ref in fullLayout axis containers
etpinard Mar 1, 2017
6a271ed
call setConvert on 3d axis during Scene.plot
etpinard Mar 1, 2017
704596a
require axis_ids instead of Axes in cartesian index
etpinard Mar 1, 2017
045da99
improve comment for setScale in lsInner
etpinard Mar 1, 2017
50d1288
Merge branch 'master' into axes-ref-cleanup
etpinard Mar 2, 2017
5eb6202
replace .map with for-loops
etpinard Mar 2, 2017
6e25640
link fullLayout.separators to ax._separators
etpinard Mar 2, 2017
9612549
replace gd._replotting -> fullLayout._replotting
etpinard Mar 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add extra karma config 
- to show console.log in terminal in karma ^1.5.0
- See karma-runner/karma@89a7a1c#commitcomment-21009216
  • Loading branch information
@etpinard
etpinard committed Mar 1, 2017
commit 170090812f8f2c92128be3e5ef1b430b662e0b24
8 changes: 8 additions & 0 deletions test/jasmine/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ function func(config) {
// See CONTRIBUTING.md for additional notes on reporting.
func.defaultConfig.logLevel = config.LOG_INFO;

// without this, console logs in the plotly.js code don't print to
// the terminal since karma v1.5.0
//
// See https://github.com/karma-runner/karma/commit/89a7a1c#commitcomment-21009216
func.defaultConfig.browserConsoleLogOptions = {
level: 'log'
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh awesome - that'll be super helpful.


config.set(func.defaultConfig);
}

Expand Down
0