10000 Add syntax test for jasmine test files by etpinard · Pull Request #139 · plotly/plotly.js · GitHub
[go: up one dir, main page]

Skip to content

Add syntax test for jasmine test files #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 22, 2015
Merged

Add syntax test for jasmine test files #139

merged 5 commits into from
Dec 22, 2015

Conversation

etpinard
Copy link
Contributor

@mdtusz @cldougl @alexcjohnson @bpostlethwaite

If ever we forget to remove an fdescribe or fit the CircleCI will now fail.

@etpinard
Copy link
Contributor Author

Error message on CircleCI:

image

@mdtusz
Copy link
Contributor
mdtusz commented Dec 21, 2015

Good check 💯!

💃

etpinard added a commit that referenced this pull request Dec 22, 2015
Add syntax test for jasmine test files
@etpinard etpinard merged commit ebdb86e into master Dec 22, 2015
@etpinard etpinard deleted the jshint-jasmine branch December 22, 2015 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0