8000 Config options coerce / schema by etpinard · Pull Request #1188 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Config options coerce / schema #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Config options coerce / schema #1188

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1417622
rewrite plot_config as valObjects
etpinard Nov 22, 2016
bea7eaf
rm (now useless) validation from frameMargins
etpinard Nov 22, 2016
8cd3ada
use gd._context instead of config file for queueLength
etpinard Nov 22, 2016
bdd7144
test: fixup frame test
etpinard Nov 22, 2016
35ade0f
test: fixup plot api test
etpinard Nov 22, 2016
e44d66f
schema: add config valObjects to PlotSchema.get() output
etpinard Nov 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use gd._context instead of config file for queueLength
  • Loading branch information
@etpinard
etpinard committed Nov 22, 2016
commit 8cd3ada5c759c7f57f622b40e0dfc6487bf54498
3 changes: 1 addition & 2 deletions src/lib/queue.js
View file
Open in desktop
7B6E
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
'use strict';

var Lib = require('../lib');
var config = require('../plot_api/plot_config');


/**
Expand Down Expand Up @@ -91,7 +90,7 @@ queue.add = function(gd, undoFunc, undoArgs, redoFunc, redoArgs) {
queueObj.redo.args.push(redoArgs);
}

if(gd.undoQueue.queue.length > config.queueLength) {
if(gd.undoQueue.queue.length > gd._context.queueLength) {
gd.undoQueue.queue.shift();
gd.undoQueue.index--;
}
Expand Down
0