8000 Refactor PlotSchema by etpinard · Pull Request #1144 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content
8000

Refactor PlotSchema #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 15, 2016
Merged

Refactor PlotSchema #1144

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8214577
schema: rm _nestedAttributes abstraction in trace modules
etpinard Nov 14, 2016
e4a9de5
schema: rm _composedModule abstraction
etpinard Nov 15, 2016
e9f679a
schema: refactor PlotSchame.get
etpinard Nov 15, 2016
8cf071b
rm component module for internal plotly index
etpinard Nov 15, 2016
7a22ca4
move (back) crawl and friends from coerce.js -> plot_schema.js
etpinard Nov 15, 2016
b56bf0c
schema: make _isLinkedToArray define name of array container items
etpinard Nov 15, 2016
b2b3829
annotations: do not export useless things
etpinard Nov 15, 2016
b9f2c8e
lint component module definitions
etpinard Nov 15, 2016
1c6b292
fill in layoutArrayContainer via Register
etpinard Nov 15, 2016
f91ebbf
schema: add frame and animation attributes
etpinard Nov 15, 2016
93fa913
lint (use variable instead of duplicating hard-coded strings)
etpinard Nov 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
annotations: do not export useless things
  • Loading branch information
@etpinard
etpinard committed Nov 15, 2016
commit b2b382904fcfa1470921218a31132ab9f3d9f055
9 changes: 0 additions & 9 deletions src/components/annotations/index.js
View file 9658
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,19 @@

'use strict';

var Plotly = require('../../plotly');

exports.moduleType = 'component';

exports.name = 'annotations';

exports.ARROWPATHS = require('./arrow_paths');

exports.layoutAttributes = require('./attributes');

exports.supplyLayoutDefaults = require('./defaults');

exports.calcAutorange = require('./calc_autorange');

exports.arrowhead = require('./draw_arrow_head');

var drawModule = require('./draw');
exports.draw = drawModule.draw;
exports.drawOne = drawModule.drawOne;

exports.add = function(gd) {
var nextAnn = gd._fullLayout.annotations.length;

Plotly.relayout(gd, 'annotations[' + nextAnn + ']', 'add');
};
0