10000 Colorscale drawing fix by etpinard · Pull Request #1112 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Colorscale drawing fix #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2016
Merged

Colorscale drawing fix #1112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72cc168
rm useless logic in drawing
etpinard Nov 4, 2016
860ccee
test: update colorscale contraint mock (to test #1109)
etpinard Nov 4, 2016
0539e28
test: add colorbars to colorscale_contraint mock
etpinard Nov 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add colorbars to colorscale_contraint mock
  • Loading branch information
< 8000 div class="flex-auto pb-2 pb-md-0">
@etpinard
etpinard committed Nov 10, 2016
commit 0539e288b75fd5c5dd8a9b9f5577628ef274b437
Binary file modified test/image/baselines/colorscale_constraint.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 18 additions & 3 deletions test/image/mocks/colorscale_constraint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@
"color": [1,2,3,4],
"cmin": 2,
"cmax": 3,
"showscale": true
"colorbar": {
"title": "trace 0",
"len": 0.3,
"y": 0,
"yanchor": "bottom"
}
}
}, {
"x": [1,2,3,4,5],
Expand All @@ -15,7 +20,12 @@
"color": [1,2,3,4],
"cmin": 1,
"cmax": 4,
"showscale": false
"colorbar": {
"title": "trace 1",
"len": 0.3,
"y": 0.3,
"yanchor": "bottom"
}
}
}, {
"x": [1,2,3,4],
Expand All @@ -24,7 +34,12 @@
"marker": {
"color": [0,0,0,0],
"size": 10,
"showscale": false
"colorbar": {
"title": "trace 2",
"len": 0.3,
"y": 0.6,
"yanchor": "bottom"
}
}
}],
"layout": {
Expand Down
0