8000 Use package to obtain webgl context by dy · Pull Request #1001 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Use package to obtain webgl context #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2016
Merged

Use package to obtain webgl context #1001

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e7c434
Use package to obtain webgl context
dy Oct 3, 2016
67d5b59
Fix eslinter
dy Oct 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
10000
Diff view
Prev Previous commit
Fix eslinter
  • Loading branch information
@dy
dy committed Oct 3, 2016
commit 67d5b5987c26216543f74280d17dcf982e58e374
2 changes: 1 addition & 1 deletion test/jasmine/assets/has_webgl_support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var getContext = require('webgl-context')
var getContext = require('webgl-context');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just gotten in the habit of running npm run lint-fix before committing, but I wouldn't necessarily recommend against a pre-commit hook that does this automatically 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologise again for our non-standard linting rules.

Copy link
Contributor Author
@dy dy Oct 3, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a rule which highlights literally every line, as far as I use windows 😆
Anyways I had to poke CI once again


module.exports = function hasWebGLSupport(testName) {
var gl, canvas;
Expand Down
0