8000 Updates in support of ggplot2 v4.0.0 by cpsievert · Pull Request #2442 · plotly/plotly.R · GitHub
[go: up one dir, main page]
Skip to content

Updates in support of ggplot2 v4.0.0 #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 5, 2025
Merged

Updates in support of ggplot2 v4.0.0 #2442

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e217ca8
Run tests against dev ggplot2
cpsievert Jun 5, 2025
d1efead
Take changes from #2440
cpsievert Jun 5, 2025
661b76d
Approve (a subset of) new snapshots
cpsievert Jun 5, 2025
6b5395d
Ensure ticktext/tickvals is atomic character/numeric vector
cpsievert Jun 5, 2025
44a6355
Fix geom_sf() break positions
cpsievert Jun 5, 2025
650725e
Fix for geom_violin()
cpsievert Jun 5, 2025
0a180d1
Update news
cpsievert Jun 5, 2025
63cc323
Approve good visual changes
cpsievert Jun 5, 2025
601ad89
Approve more visual changes; fix test expectation
cpsievert Jun 5, 2025
8000
f0fb1e0
Accept new snapshot
cpsievert Jun 5, 2025
2811e61
Zero length ticktext/tickvals should remain NULL
cpsievert Jun 5, 2025
fb012d8
Zero length vs NULL can actually be meaningful so just safe guard aga…
cpsievert Jun 5, 2025
66fb4d8
Approve new snapshot
cpsievert Jun 5, 2025
4226314
Refactor
cpsievert Jun 5, 2025
a94e95d
Update NEWS.md
cpsievert Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Approve more visual changes; fix test expectation
  • Loading branch information
@cpsievert
cpsievert committed Jun 5, 2025
commit 601ad894c8ad64e7da86213b5698122d2f7ec780
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-legend/guide-aes-none.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-polygons/polygons-canada-borders.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-sf/sf-points.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-ticks/ticks-hide-ticks-lines-labels.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading
0