8000 Bug fix: allow empty `Vlines` and `Hlines` as `ggplot2` does by dereckmezquita · Pull Request #2252 · plotly/plotly.R · GitHub
[go: up one dir, main page]
Skip to content

Bug fix: allow empty Vlines and Hlines as ggplot2 does #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 3, 2023
Merged

Bug fix: allow empty Vlines and Hlines as ggplot2 does #2252

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
209d6b3
Vlines and Hlines might sometimes be inexistant; ggplot2 allows this …
dereckdemezquita Apr 9, 2023
dfd9835
Unit test for allowing empty vlines.
dereckdemezquita Apr 9, 2023
27bba16
Added horizontal line test.
dereckdemezquita Apr 9, 2023
6090855
If data is greater than nrow 0; better data check.
dereckdemezquita Apr 11, 2023
d254419
Simplified example data and corrected expected result in expect_error…
dereckdemezquita Apr 11, 2023
9ca4b74
Tests with simplified data; did both cases succesful plot and what wa…
dereckdemezquita Apr 11, 2023
28bbbc4
Separated tests into respective files; horizontal/vertical.
dereckdemezquita Apr 15, 2023
4be8e7f
Seed for reproducibility.
dereckmezquita Jun 3, 2023
bbf07fe
Seed for reproducibility.
dereckmezquita Jun 3, 2023
333d311
Simplify tests.
dereckmezquita Jun 3, 2023
5bb68a9
Simplified test.
dereckdemezquita Jun 3, 2023
ca4ccd5
Unnecessary comment.
dereckmezquita Jun 3, 2023
49dda5c
vline/hline empty df news fix.
dereckdemezquita Jun 3, 2023
19a65ea
Issue closes both functione errors.
dereckdemezquita Jun 3, 2023
95cbcbd
American English!
dereckdemezquita Jun 3, 2023
76b5b38
Don't need number at the ned.
dereckdemezquita Jun 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't need number at the ned.
  • Loading branch information
@dereckdemezquita
dereckdemezquita committed Jun 3, 2023
commit 76b5b387a221a215d38a9330615fe096c61c0712
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* Closed #2208: `ggplotly()` no longer errors given a `geom_area()` with 1 or less data points (error introduced by new behavior in ggplot2 v3.4.0). (#2209)
* Closed #2220: `ggplotly()` no longer errors on `stat_summary(geom = "crossbar")`. (#2222)
* Closed #2212: `ggplotly()` no longer removes legends when setting guide properties via `guides(aes = guide_xxx(...))`.
* Closed #1947: `ggplotly()` now correctly handles `geom_vline`/`geom_hline` with empty data. Previously, if `geom_vline`/`geom_hline` was passed an empty data frame, it would result in an error. The plot is drawn even if no lines are found; this is the same behavior as `ggplot2`. (#1947)
* Closed #1947: `ggplotly()` now correctly handles `geom_vline`/`geom_hline` with empty data. Previously, if `geom_vline`/`geom_hline` was passed an empty data frame, it would result in an error. The plot is drawn even if no lines are found; this is the same behavior as `ggplot2`.

# 4.10.1

Expand Down
0