8000 Handle geom_tile() with no fill aesthetic by cpsievert · Pull Request #2063 · plotly/plotly.R · GitHub
[go: up one dir, main page]
Skip to content

Handle geom_tile() with no fill aesthetic #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Handle geom_tile() with no fill aesthetic #2063

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae7cd4b
Close #1562: handle geom_tile() with no fill aesthetic
cpsievert Nov 1, 2021
0af684b
add visual test
cpsievert Nov 1, 2021
3cb46d4
update news
cpsievert Nov 1, 2021
3cd116f
Merge branch 'master' into tile-no-fill
cpsievert Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loa 8000 ding
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add visual test
  • Loading branch information
@cpsievert
cpsievert committed Nov 1, 2021
commit 0af684b0ec00d48a26755f629f25d6cf92bae6f6
9 changes: 9 additions & 0 deletions tests/testthat/test-ggplot-heatmap.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,12 @@ test_that("geom_tile() with discrete x/y", {
expect_equivalent(L$data[[1]]$type, "heatmap")
})

test_that("geom_tile() with no fill aesthetic", {
df <- data.frame(
x = rep(c(2, 5, 7, 9, 12), 2),
y = rep(c(1, 2), each = 5)
)
p <- ggplot(df, aes(x, y)) + geom_tile(colour = "grey50")
expect_doppelganger(ggplotly(p), "tile-no-fill")
})

0