8000 Add stat_ecdf support by moutikabdessabour · Pull Request #2052 · plotly/plotly.R · GitHub
[go: up one dir, main page]
Skip to content

Add stat_ecdf support #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add stat_ecdf support #2052

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6f1901
Fixed the way `GeomStep` was handeled. Closes #2011
moutikabdessabour Oct 22, 2021
943304b
Fixed some issues with the tests. And added new ones.
moutikabdessabour Oct 22, 2021
660be52
Added bug fix to NEWS.md
moutikabdessabour Oct 22, 2021
c36bd61
Conformed with carson's review
moutikabdessabour Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
8000 Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Conformed with carson's review
  • Loading branch information
@moutikabdessabour
moutikabdessabour committed Nov 2, 2021
commit c36bd61bc1d8a5cc5d5d551600c3977e07359ef6
5 changes: 2 additions & 3 deletions R/layers2traces.R
9531 View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ to_basic.GeomLine <- function(data, prestats_data, layout, params, p, ...) {

#' @export
to_basic.GeomStep <- function(data, prestats_data, layout, params, p, ...) {
prefix_class(if((params$direction %||% "vh") %in% c("vh", "hv", "mid")) ggplot2:::stairstep(data, direction = params$direction) else data, c("GeomPath", "GeomStep"))
prefix_class(if((params$direction %||% "vh") %in% c("vh", "hv", "mid")) ggfun("stairstep")(data, direction = params$direction) else data, c("GeomPath", "GeomStep"))
}

#' @export
Expand Down Expand Up @@ -623,8 +623,7 @@ to_basic.GeomQuantile <- function(data, prestats_data, layout, params, p, ...){
}

#' @export
to_basic.default<- function(data, prestats_data, layout, params, p, ...) {

to_basic.default <- function(data, prestats_data, layout, params, p, ...) {
data
}

Expand Down
0