8000 Added fable/feast support by moutikabdessabour · Pull Request #2045 · plotly/plotly.R · GitHub
[go: up one dir, main page]
Skip to content

Added fable/feast support #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added fable/feast support #2045

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8415e2b
Closes #1568. Implemented `to_basic` for `fabletools:::autoplot.fbl_ts`.
moutikabdessabour Oct 13, 2021
c876c1d
Added visual tests.
moutikabdessabour Oct 13, 2021
c240972
Modified the visual tests to better showcase the functionality.
moutikabdessabour Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8000
Prev Previous commit
Modified the visual tests to better showcase the functionality.
  • Loading branch information
@moutikabdessabour
moutikabdessabour committed Oct 13, 2021
commit c240972c2b92bd672551bb46ce77c0cf305f4c29
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/fabletools/autoplot-fable.svg
View file
Open in desktop
Loading
986A Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 6 additions & 3 deletions tests/testthat/test-fabletools.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
test_that("mimics the autoplot output", {
# taken from https://fable.tidyverts.org/articles/fable.html
p <- tsibble::tourism %>%
data <- tsibble::tourism %>%
filter(Region == "Melbourne") %>%
`[`(, c("Quarter", "Trips", "Region")) %>%
distinct(Quarter, .keep_all = TRUE) %>%
as_tsibble(key = Region)
p <- data %>%
model(
ets = ETS(Trips ~ trend("A")),
arima = ARIMA(Trips)
) %>%
forecast(h = "5 years") %>%
autoplot(tourism_melb)
autoplot(data)
expect_doppelganger(ggplotly(p), "autoplot-fable")
})
0