8000 Solved the LaTeX2exp error. Closes #2027 by moutikabdessabour · Pull Request #2030 · plotly/plotly.R · GitHub
[go: up one dir, main page]
Skip to content

Solved the LaTeX2exp error. Closes #2027 #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 1, 2021
Merged

Solved the LaTeX2exp error. Closes #2027 #2030

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
453b10e
Solved the LaTeX2exp error. Closes #2027
moutikabdessabour Sep 28, 2021
823c516
Solved issues with the checks
moutikabdessabour Sep 28, 2021
ee146c5
Solved issues with the checks
moutikabdessabour Sep 28, 2021
71df890
Trying to solve the issue with the checks.
moutikabdessabour Sep 28, 2021
e559130
Trying to solve the issue with the checks.
moutikabdessabour Sep 28, 2021
ea35806
Trying to solve the issue with the checks.
moutikabdessabour Sep 28, 2021
99cd9da
R-CMD-CHECK warning resolved.
moutikabdessabour Sep 28, 2021
e27621c
Conformed with the review
moutikabdessabour Sep 28, 2021
d915b9c
Reverted changes to the _snaps folder
moutikabdessabour Oct 9, 2021
37a4ae6
Use `basename(file)` instead of file as the directory has already cha…
moutikabdessabour Oct 9, 2021
6fb00c9
Added a test that showcases this functionality
moutikabdessabour Oct 9, 2021
8c765f1
Added informative test message
moutikabdessabour Oct 9, 2021
6d29bad
Removing `TeX` class easily
moutikabdessabour Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Trying to solve the issue with the checks.
  • Loading branch information
@moutikabdessabour
moutikabdessabour committed Sep 28, 2021
commit 71df890108e563837aa3780eb2dc2958e5e7dd9a
5 changes: 4 additions & 1 deletion R/ggplotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,25 +1301,28 @@ bold <- function(x) paste("<b>", x, "</b>")
italic <- function(x) paste("<i>", x, "</i>")

# generic S3 method to allow for class specific implementations
#' @export
uniq <- function(x){
UseMethod("uniq", x)
}

# if a vector that has one unique value (ignoring missings), return that value
#' @export
uniq.default <- function(x) {
u <- unique(x)
if (identical(u, NA) || length(u) == 0) return(u)
u <- u[!is.na(u)]
if (length(u) == 1) u else x
}

#' @export
uniq.NULL <- function(x) {
x
}

# if TeX object convert to character first
uniq.TeX <- function(x){
print(uniq(as.character(x)))
uniq(as.character(x))
}

# theme(strip.background) -> plotly.js rect shape
Expand Down
0