8000 ggplotly() failed when labels or title were a factor, because nchar()… by dmurdoch · Pull Request #1773 · plotly/plotly.R · GitHub
[go: up one dir, main page]
Skip to content

ggplotly() failed when labels or title were a factor, because nchar()… #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2020
Merged

ggplotly() failed when labels or title were a factor, because nchar()… #1773

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15aca2b
ggplotly() failed when labels or title were a factor, because nchar()…
dmurdoch May 19, 2020
5b2ee0f
Better naming, fix #1731 as well, add tests
dmurdoch May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ggplotly() failed when labels or title were a factor, because nchar()… 
… doesn't like factors.
  • Loading branch information
@dmurdoch
dmurdoch committed May 19, 2020
commit 15aca2bc89a34400713515c1d7bfa62bd004f2e0
28 changes: 16 additions & 12 deletions R/ggplotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ ggplotly.plotly <- function(p = ggplot2::last_plot(), width = NULL, height = NUL
p
}

# nchar() needs a character vector; sometimes x will be a
# factor
nchar0 <- function(x, ...) nchar(as.character(x), ...)

#' @export
ggplotly.ggmatrix <- function(p = ggplot2::last_plot(), width = NULL,
height = NULL, tooltip = "all", dynamicTicks = FALSE,
Expand Down Expand Up @@ -127,7 +131,7 @@ ggplotly.ggmatrix <- function(p = ggplot2::last_plot(), width = NULL,
titleY = TRUE, titleX = TRUE) %>%
hide_legend() %>%
layout(dragmode = "select")
if (nchar(p$title %||% "") > 0) {
if (nchar0(p$title %||% "") > 0) {
s <- layout(s, title = p$title)
}
for (i in seq_along(p$xAxisLabels)) {
Expand Down Expand Up @@ -436,7 +440,7 @@ gg2list <- function(p, width = NULL, height = NULL,
font = text2font(theme$text)
)
# main plot title
if (nchar(plot$labels$title %||% "") > 0) {
if (nchar0(plot$labels$title %||% "") > 0) {
gglayout$title <- list(
text = faced(plot$labels$title, theme$plot.title$face),
font = text2font(theme$plot.title),
Expand Down Expand Up @@ -567,7 +571,7 @@ gg2list <- function(p, width = NULL, height = NULL,
# allocate enough space for the _longest_ text label
axisTextX <- theme[["axis.text.x"]] %||% theme[["axis.text"]]
labz <- unlist(lapply(layout$panel_params, function(pp) { pp[["x"]]$get_labels %()% pp$x.labels }))
lab <- labz[which.max(nchar(labz))]
lab <- labz[which.max(nchar0(labz))]
panelMarginY <- panelMarginY + axisTicksX +
bbox(lab, axisTextX$angle, unitConvert(axisTextX, "npc", "height"))[["height"]]
}
Expand All @@ -579,7 +583,7 @@ gg2list <- function(p, width = NULL, height = NULL,
# allocate enough space for the _longest_ text label
axisTextY <- theme[["axis.text.y"]] %||% theme[["axis.text"]]
labz <- unlist(lapply(layout$panel_params, function(pp) { pp[["y"]]$get_labels %()% pp$y.labels }))
lab <- labz[which.max(nchar(labz))]
lab <- labz[which.max(nchar0(labz))]
panelMarginX <- panelMarginX + axisTicksY +
bbox(lab, axisTextY$angle, unitConvert(axisTextY, "npc", "width"))[["width"]]
}
Expand Down Expand Up @@ -806,15 +810,15 @@ gg2list <- function(p, width = NULL, height = NULL,

# do some stuff that should be done once for the entire plot
if (i == 1) {
axisTickText <- axisObj$ticktext[which.max(nchar(axisObj$ticktext))]
axisTickText <- axisObj$ticktext[which.max(nchar0(axisObj$ticktext))]
side <- if (xy == "x") "b" else "l"
# account for axis ticks, ticks text, and titles in plot margins
# (apparently ggplot2 doesn't support axis.title/axis.text margins)
gglayout$margin[[side]] <- gglayout$margin[[side]] + axisObj$ticklen +
bbox(axisTickText, axisObj$tickangle, axisObj$tickfont$size)[[type]] +
bbox(axisTitleText, axisTitle$angle, unitConvert(axisTitle, "pixels", type))[[type]]

if (nchar(axisTitleText) > 0) {
if (nchar0(axisTitleText) > 0) {
axisTextSize <- unitConvert(axisText, "npc", type)
axisTitleSize <- unitConvert(axisTitle, "npc", type)
offset <-
Expand All @@ -836,7 +840,7 @@ gg2list <- function(p, width = NULL, height = NULL,
}
# facets have multiple axis objects, but only one title for the plot,
# so we empty the titles and try to draw the title as an annotation
if (nchar(axisTitleText) > 0) {
if (nchar0(axisTitleText) > 0) {
# npc is on a 0-1 scale of the _entire_ device,
# but these units _should_ be wrt to the plotting region
# multiplying the offset by 2 seems to work, but this is a terrible hack
Expand Down Expand Up @@ -873,7 +877,7 @@ gg2list <- function(p, width = NULL, height = NULL,
)
if (is_blank(theme[["strip.text.x"]])) col_txt <- ""
if (inherits(plot$facet, "FacetGrid") && lay$ROW != 1) col_txt <- ""
if (nchar(col_txt) > 0) {
if (nchar0(col_txt) > 0) {
col_lab <- make_label(
col_txt, x = mean(xdom), y = max(ydom),
el = theme[["strip.text.x"]] %||% theme[["strip.text"]],
Expand All @@ -890,7 +894,7 @@ gg2list <- function(p, width = NULL, height = NULL,
)
if (is_blank(theme[["strip.text.y"]])) row_txt <- ""
if (inherits(plot$facet, "FacetGrid") && lay$COL != nCols) row_txt <- ""
if (nchar(row_txt) > 0) {
if (nchar0(row_txt) > 0) {
row_lab <- make_label(
row_txt, x = max(xdom), y = mean(ydom),
el = theme[["strip.text.y"]] %||% theme[["strip.text"]],
Expand Down Expand Up @@ -1180,7 +1184,7 @@ is_blank <- function(x) {
# given text, and x/y coordinates on 0-1 scale,
# convert ggplot2::element_text() to plotly annotation
make_label <- function(txt = "", x, y, el = ggplot2::element_text(), ...) {
if (is_blank(el) || is.null(txt) || nchar(txt) == 0 || length(txt) == 0) {
if (is_blank(el) || is.null(txt) || nchar0(txt) == 0 || length(txt) == 0) {
return(NULL)
}
angle <- el$angle %||% 0
Expand Down Expand Up @@ -1215,9 +1219,9 @@ has_facet <- function(x) {

bbox <- function(txt = "foo", angle = 0, size = 12) {
# assuming the horizontal size of a character is roughly half of the vertical
n <- nchar(txt)
n <- nchar0(txt)
if (sum(n) == 0) return(list(height = 0, width = 0))
w <- size * (nchar(txt) / 2)
w <- size * (nchar0(txt) / 2)
angle <- abs(angle %||% 0)
# do the sensible thing in the majority of cases
if (angle == 0) return(list(height = size, width = w))
Expand Down
0