8000 Bump plotly.js version by cpsievert · Pull Request #1178 · plotly/plotly.R · GitHub
[go: up one dir, main page]

Skip to content

Bump plotly.js version #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 25, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up wording
  • Loading branch information
cpsievert committed Jan 24, 2018
commit 35fe715b8b789dbf376b7930b2fdbce9b13372a1
4 changes: 2 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

## NEW FEATURES & IMPROVEMENTS

* Upgraded to plotly.js v1.33.0. A _huge_ amount of features and improvements have been made since v1.29.2 (i.e., the version included in the last CRAN release of the R package - v4.7.1). Read the complete list of changes here: <https://github.com/plotly/plotly.js/releases>.
* Persistent selection can now be enabled via the 'shift' key. It's still possible to _force_ persistent selection by setting `persistent = TRUE` in `highlight()`, but `persistent = FALSE` (the default) is now recommended since it allows one to switch between [transient/persistent selection](https://plotly-book.cpsievert.me/linking-views-without-shiny.html#transient-versus-persistent-selection) in the browser, rather than at the command line.
* Upgraded to plotly.js v1.33.0. A _huge_ amount of features and improvements have been made since v1.29.2 (i.e., the version included in the last CRAN release of the R package - v4.7.1). Highlights include a complete re-write of `scattergl` to make it nearly feature complete with `scatter`, localization of text rendering (i.e., international translations), and two new trace types (`violin` & `table`). Read more about the v1.32.0 release [here](https://codeburst.io/notes-from-the-latest-plotly-js-release-b035a5b43e21) and the complete list of changes [here](https://github.com/plotly/plotly.js/releases).
* The selection mode can now switch from 'transient' to 'persistent' by holding the 'shift' key. It's still possible to _force_ persistent selection by setting `persistent = TRUE` in `highlight()`, but `persistent = FALSE` (the default) is now recommended since it allows one to switch between [persistent/transient selection](https://plotly-book.cpsievert.me/linking-views-without-shiny.html#transient-versus-persistent-selection) in the browser, rather than at the command line.

## CHANGES

Expand Down
11 changes: 5 additions & 6 deletions R/highlight.R
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ highlight <- function(p, on = "plotly_click", off,
stop("opacityDim must be between 0 and 1", call. = FALSE)
}
if (dynamic && length(color) < 2) {
message("Adding more colors to the selection color palette")
message("Adding more colors to the selection color palette.")
color <- c(color, RColorBrewer::brewer.pal(4, "Set1"))
}
if (!dynamic && length(color) > 1) {
warning(
"Can only use a single color for selections when dynamic=FALSE",
"Can only use a single color for selections when `dynamic = FALSE`.",
call. = FALSE
)
color <- color[1]
Expand Down Expand Up @@ -139,10 +139,9 @@ highlight <- function(p, on = "plotly_click", off,

if (isTRUE(persistent)) {
message(
"Persistent selection can now be enabled via the 'shift' key. ",
"Thus, it's recommended to use the default (persistent = FALSE) since ",
"this allows one to switch between persistent/transient selection ",
"'on-demand' (in the browser)."
"We recommend setting `persistent` to `FALSE` (the default) because ",
"persistent selection mode can now be used by holding the shift key ",
"(while triggering the `on` event)."
)
}

Expand Down
0