Faster CircleCI tests + better docker image docs#211
Merged
Conversation
we already run the unit tests in the `jl_test`, we save 2-3 minutes of CI time by dropping `ci_prepare.jl` and replacing it by `Pkg.instantiate()`
inside the "Integration tests" command block, as it is now useless.
the `dash-main` folder the repo root is used during the integration tests to install the python testing deps
so that it includes info on when and how to update the image and how to run the integration tests locally.
etpinard
commented
Jun 28, 2023
| - run: | ||
| name: ⚙️ Integration tests | ||
| command: | | ||
| julia --project -e 'import Pkg; Pkg.instantiate(); Pkg.update();' |
Collaborator
Author
There was a problem hiding this comment.
N.B. we now install the Julia deps in the repo environment as we now assume that the Julia test runner uses julia --project internally following plotly/dash#2573
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moreover, the CI failure reported in #210 (comment) seems to be gone now 😄