Adding Azure ARM provider (azure-v2) #550
Conversation
Added destroy server and example for it
# Conflicts: # lib/pkgcloud/azure-v2/utils/azureApiV2.js
|
@morsh first: thanks for your contribution; we appreciate it! One question: is there any reason to leave around the |
|
Hi @indexzero, Microsoft is encouraging people to move to ARM (v2), but I would keep v1 support since there are still many people using ASM (v1) and Microsoft will keep supporting ASM. Nonetheless, all new development are only in the ARM API as well as upgrades etc. |
|
Hi @indexzero ,
Thanks! |
|
@morsh @indexzero Perhaps it makes sense to rename the old azure provider to |
|
@morsh FYI those two tests were failing due to an expired auth token in the |
|
@rosskukulinski Thanks! |
|
@rosskukulinski @jcrugzz @guymguym @dscape @cronopio @indexzero Cheers. |
|
@morsh Did you see the jshint failures on TravisCI? |
|
@morsh Also notice that this project is still running with node 0.10 (old) where arrow functions are not supported yet by the V8 engine, and your code is full of them, so it's probably why tests will fail anyhow even after jshint will pass. |
|
Do you have any plans to upgrade to a newer version of Node anytime soon? Or would that cause too many dependencies breaking in the general code base? Just wondering, because Node 0.10 is fairly old... |
getting updates from main repo
will support win32-openssh for windows and will add default user to sudoers for linux
adding ssh support for both linux and windows
|
Hi @rosskukulinski @jcrugzz @guymguym @dscape @cronopio @indexzero, Reminder: We need to understand how the tests work so we can add our own and finalize the pull request. Cheers. |
small urgent fix
miniature fix for running ssh on windows
Since this is a major pull request, I want to submit it before it is ready to make sure the code is aligned with the repo's requirements.
This is related to case: #545
All code added under [azure-v2] provider.