fix S_IFMT value on windows, plan9 and js/wasm #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 30, 2019
puellanivis
reviewed
Dec 31, 2019
syscall_fixed.go
Outdated
| @@ -0,0 +1,5 @@ | |||
| // +build plan9 windows | |||
There was a problem hiding this comment.
We probably also want this for js,wasm:
https://github.com/golang/go/blob/master/src/syscall/syscall_js.go#L159
c38be39 to
d9b1aad
Compare
Go defines S_IFMT on windows, plan9 and js/wasm as 0x1f000 instead of 0xf000. None of the the other S_IFxyz values (even on those mentioned) include the "1" (in 0x1f000) which prevents them from matching the bitmask. This fixes that by overriding the S_IFMT value on the effected platforms to be 0xf000, as it it on all others.
d9b1aad to
0277caa
Compare
|
I added js/wasm, updated the commit message and added a comment to the _fixed version noting the reasoning. |
puellanivis
approved these changes
Jan 3, 2020
|
Thanks. I had to double check the build tags as well. First time I had a that logic combo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go defines S_IFMT on windows, plan9 and js/wasm as 0x1f000 instead of 0xf000. None of the the other S_IFxyz values include the "1" (in 0x1f000) which prevents them from matching the bitmask.
This fixes that by overriding the S_IFMT value on the effected platforms to be 0xf000, as it it on all the others.
Fixes #291