8000 chore: add PR performance benchmark workflow by Zyie · Pull Request #11729 · pixijs/pixijs · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@Zyie
Copy link
Member
@Zyie Zyie commented Oct 23, 2025

Implements an automated workflow to run performance benchmarks on pull requests.
Compares the PR's performance against the main development branch baseline.

@pkg-pr-new
Copy link
pkg-pr-new bot commented Oct 23, 2025

pixi.js-basepixi.js-bunny-mark

npm i https://pkg.pr.new/pixijs/pixijs/pixi.js@11729

commit: 8ec466d

Implements an automated workflow to run performance benchmarks on pull requests.
Compares the PR's performance against the main development branch baseline.
@github-actions
Copy link
github-actions bot commented Oct 24, 2025

PixiJS Benchmark Results (dev CDN vs local dist)

Name dev Avg FPS local Avg FPS Δ% Trend
graphics 38.30 43.83 -14.42% 🔺
sprite 36.58 42.98 -17.48% 🔺
sprite-slow 42.92 41.61 3.06% 🔻
text 26.96 23.66 12.24% 🔻

❌ Performance regression detected (> 5% slower than dev)

@Zyie Zyie marked this pull request as ready for review October 24, 2025 09:34
@bigtimebuddy
Copy link
Member

What is the reason the the performance benchmark in another repo? Why not add it here?

@Zyie
Copy link
Member Author
Zyie commented Oct 24, 2025

What is the reason the the performance benchmark in another repo? Why not add it here?

I was mostly thinking to avoid bloating the main repo as we add more benchmarks
I happy to move it over though if you like?

@bigtimebuddy
Copy link
Member

The challenge of keeping it external is that it creates an upstream dependency on our repo. Say for instance, that we change an interface or some API it would require us to update the benchmark or we'd be blocked. Because of that coupling, I would say that it makes more sense to keep it in this repo.

Introduces two new benchmarks to measure the performance of rendering and animating specific display objects. One focuses on Graphics objects, animating many circles with redrawing operations. The other targets Text objects, animating position and dynamically updating font sizes to simulate heavier CPU load. These additions provide dedicated tests for assessing rendering efficiency and identifying performance changes in these key PixiJS components.
@Zyie
Copy link
Member Author
Zyie commented Nov 6, 2025

going to convert this one back to a draft as the consistency disappears with the more tests that are run

@Zyie Zyie marked this pull request as draft November 6, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0