Use getFTLPID instead of pidof
#313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rdwebdesign
requested changes
Dec 26, 2022
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. |
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
rdwebdesign
previously approved these changes
Dec 28, 2022
Signed-off-by: Christian König <ckoenig@posteo.de>
Member
Author
|
Added a small visual improvement. |
DL6ER
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Currently, we use
pidofto test ifFTLis running. However, there are hints thatpidofmight be a bit unreliable to find all processes. See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926896 and https://unix.stackexchange.com/questions/518411/why-is-pidof-not-workingThis as also been reported in one of our issues: #307 (comment)
How does this PR accomplish the above?:
pidofwithgetFTLPID, a function that we also use incore. It'll read thePIDfrompihole-FTL.pidfileFTLwrites on it's start.hoption to thepscommand for gettingFTLs CPU and memory utilization to save one pipe totail.By submitting this pull request, I confirm the following:
git rebase)