Support for Virtualbox 6.1 #210#213
Support for Virtualbox 6.1 #210#213h6w merged 2 commits intophpvirtualbox:developfrom cesium147:6.1-0
Conversation
|
This should go in a |
|
Could you merge? It's working perfectly! |
|
I see WDSL has been updated. People should test if creating snapshots works before considering to merge. This is the reason I refused to update WDSL in previous patches. @Jasmich would you be willing to try creating a snapshot from within phpVirtualBox and see if the snaphot becomes visible? If you even get this far, all other snapshot commands also need to be tested. |
|
No, snapshots do not seem to work. |
|
Well, that's a showstopper as it breaks major functionality. And @trasherdk I disagree in creating two branches, develop should be capable of supporting 6.1 while providing backwards compatibility with previous versions. And ideally this is going to happen quickly. |
|
This change in vboxconnector.php works, but not entirely sure what it means. See "5.107.82 takeSnapshot", page 245, SDKRef.pdf. This should perhaps be the state of paused... although when testing, true or false doesn't seem to make a difference. Maybe something else related to snapshots needs support in phpvirtualbox. I've not used live snapshots with virtualbox before. @@ -4706,7 +4706,7 @@ class vboxconnector {
$machine->lockMachine($this->session->handle, ((string)$machine->sessionState == 'Unlocked' ? 'Write' : 'Shared'));
/* @var $progress IProgress */
- list($progress, $snapshotId) = $this->session->machine->takeSnapshot($args['name'], $args['description'], null);
+ list($progress, $snapshotId) = $this->session->machine->takeSnapshot($args['name'], $args['description'], false);
// Does an exception exist?
try { |
|
Thanks @unbob, i applied you patch |
|
Fantastic, @cesium147 and @unbob! Testers, can you check if everything works now? I'm currently busy elsewhere. Can someone also test if this works with VirtualBox 6.0 (and maybe 5.2) too? @h6w would you be so nice to review this PR with priority please? I would rebase two outstanding PRs from here. |
|
Thanks @cesium147! Good quality patch. There's an extraneous newline but I also concur with another patch that CRLF is no longer necessary in modern browsers so we'll filter that out later. Also note that my comparison of this wsdl with the one on the VBox website 6.1.2 is that we now have a new network adapter: The wsdl in this patch therefore must be from a previous 6.1 release. I won't be doing an official 6.1 release until the heavy reports of issues with the master branch dies down a bit - many of the issues seem to be serious and unclear and I don't want to make things worse. Sorry for being a bit quiet. I'm focusing on removing flash at the moment as that's an impending deadline, particularly since Edge just moved to Webkit so we're going to be pretty much a two-tiered web soon - Webkit vs Gecko. |
No description provided.