8000 Prevent access to .git/ directory by clcain · Pull Request #205 · phpvirtualbox/phpvirtualbox · GitHub
[go: up one dir, main page]

Skip to content

Prevent access to .git/ directory#205

Merged
h6w merged 1 commit intophpvirtualbox:developfrom
clcain:develop
Oct 13, 2019
Merged

Prevent access to .git/ directory#205
h6w merged 1 commit intophpvirtualbox:developfrom
clcain:develop

Conversation

@clcain
Copy link
Contributor
@clcain clcain commented Oct 11, 2019

I installed phpVirtualBox from source and noticed that the .git/ directory was available publicly via HTTP. As this could be a security vulnerability, I figured it would be good to make sure to blacklist everything in .git/.

@trasherdk
Copy link

One could argue that you should not run phpVirtualBox out of your dev environment.

And, how could the contents of .git become an vulnerability?
Does that directory contain anything not available on github?

@clcain
Copy link
Contributor Author
clcain commented Oct 11, 2019

Just trying to prevent unexpected behavior. I would hope nothing private is in the git history, but I can imagine someone not being aware that their commits are being hosted along with the application.

@trasherdk
Copy link

I would be more concerned about the login being exposed to random drive-by hacking attempts.
Your installation should be protected by more than a simple login.

@h6w
Copy link
Contributor
h6w commented Oct 13, 2019

@trasherdk 's point is valid. A good sysadmin should protect it in multiple ways (My deployments aren't even accessible publicly but only via VPN/SSH/Virtual/Host/Local Network with 2FA.) However, @clcain 's point is that it's a possibility, and this is a simple fix, I'm going to allow it. Thanks for the suggestion!

@h6w h6w merged commit 3c981d4 into phpvirtualbox:develop Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0